Skip to content

Conversation

a-maurice
Copy link
Contributor

@a-maurice a-maurice commented May 23, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

JniResultCallback was using two separate locks, with no guarantee on which will be grabbed first. This could cause a deadlock, leading to ANRs. Fix this by just using a single lock.

Addresses issues like: firebase/quickstart-unity#1286


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Building locally, plus GHA tests


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label May 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 23, 2023
@github-actions
Copy link

github-actions bot commented May 23, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 8f8718b
Last updated: Wed May 24 16:02 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  SmokeTest.TestObservesNewDocument
gma [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2023
@a-maurice a-maurice requested a review from jonsimantov May 24, 2023 17:13
@a-maurice a-maurice merged commit 8f8718b into main May 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 24, 2023
@a-maurice a-maurice deleted the am-jni_callback_deadlock branch May 24, 2023 22:06
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2023
@firebase firebase locked and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants