-
Notifications
You must be signed in to change notification settings - Fork 126
Handle time zone environment variable having international characters. #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit 974fb07
Add flaky tests to go/fpl-cpp-flake-tracker |
…ub.com/firebase/firebase-cpp-sdk into remote-config-international-characters
FYI not planning to merge until after the Unity release, just to be safe. |
Unity build and tests succeeded here: https://github.com/firebase/firebase-unity-sdk/actions/runs/5138069241 |
Removed the extraneous log statements and added a comment to the cmake file. |
Description
Avoid sending the backend the wrong time zone format (or one with international characters) by using the Windows ICU library to get the canonical IANA time zone names (e.g. "America/Los Angeles").
Previously, on Windows, it used the "TZ" environment variable verbatim. This could have contained international characters (see #869). Now, use _tzset() to get the canonical Windows name, and then use the ICU library to convert it to the IANA name, which the Remote Config backend expects.
Testing
Tested with "Romance Standard Time" --> "Europe/Paris" with LogInfo, prior to changing back to LogDebug.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.