Skip to content

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 24, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Avoid sending the backend the wrong time zone format (or one with international characters) by using the Windows ICU library to get the canonical IANA time zone names (e.g. "America/Los Angeles").

Previously, on Windows, it used the "TZ" environment variable verbatim. This could have contained international characters (see #869). Now, use _tzset() to get the canonical Windows name, and then use the ICU library to convert it to the IANA name, which the Remote Config backend expects.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Tested with "Romance Standard Time" --> "Europe/Paris" with LogInfo, prior to changing back to LogDebug.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label May 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 24, 2023
@github-actions
Copy link

github-actions bot commented May 24, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 974fb07
Last updated: Thu Jun 1 19:16 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAppCheckTest.TestDebugProviderValidToken
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 24, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 25, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels May 25, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 25, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 25, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 25, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 25, 2023
@github-actions github-actions bot removed the tests: succeeded This PR's integration tests succeeded. label May 31, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 31, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 31, 2023
@jonsimantov jonsimantov marked this pull request as ready for review June 1, 2023 00:51
@jonsimantov jonsimantov requested a review from a-maurice June 1, 2023 00:51
@jonsimantov
Copy link
Contributor Author

FYI not planning to merge until after the Unity release, just to be safe.

@jonsimantov
Copy link
Contributor Author

Unity build and tests succeeded here: https://github.com/firebase/firebase-unity-sdk/actions/runs/5138069241

@jonsimantov
Copy link
Contributor Author

Removed the extraneous log statements and added a comment to the cmake file.

@jonsimantov jonsimantov enabled auto-merge (squash) June 1, 2023 23:19
@jonsimantov jonsimantov merged commit 974fb07 into main Jun 1, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 1, 2023
@jonsimantov jonsimantov deleted the remote-config-international-characters branch June 2, 2023 00:00
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 2, 2023
@firebase firebase locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants