Skip to content

Add a summary of the most often failing tests to the daily build report #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 16, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 14, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Add a table of the failures/flakes that occur most often to the build summary.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Example: #1179 (unless it's been overridden)


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 14, 2023
@jonsimantov jonsimantov marked this pull request as ready for review June 15, 2023 15:06
@jonsimantov jonsimantov requested a review from a-maurice June 15, 2023 15:06
@jonsimantov jonsimantov enabled auto-merge (squash) June 16, 2023 00:33
@jonsimantov jonsimantov disabled auto-merge June 16, 2023 00:49
@jonsimantov jonsimantov merged commit 39c8aa6 into main Jun 16, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 16, 2023
@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 39c8aa6
Last updated: Fri Jun 16 02:35 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAppCheckTest.TestDebugProviderValidToken
firestore [TEST] [FLAKINESS] [Android] [2/3 os: macos windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 16, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 16, 2023
@firebase firebase locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants