Skip to content

Distribute FTL tests amongst different device models #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 12, 2023
Merged

Distribute FTL tests amongst different device models #1468

merged 11 commits into from
Oct 12, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Oct 10, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Distributing the load will help prevent issues with a single FTL device type from bottlenecking the tests.

Depends on FirebaseExtended/github-actions#7 being merged and a new release of the firebase-test-lab action created.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running expanded tests on this PR.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Oct 10, 2023
@jonsimantov jonsimantov added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Oct 10, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit b50057e
Last updated: Thu Oct 12 15:09 PDT 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: android_target]
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaUmpTest.TestUmpMethodsReturnOperationInProgress
storage [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseStorageTest.TestWriteAndReadFileWithCustomMetadata

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov requested a review from sunmou99 October 10, 2023 20:36
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 10, 2023
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Oct 10, 2023
@github-actions github-actions bot removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Oct 10, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 11, 2023
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Oct 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 11, 2023
@sunmou99
Copy link
Contributor

LGTM

@sunmou99 sunmou99 added the skip-release-notes Skip release notes check label Oct 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Oct 11, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 11, 2023
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Oct 11, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels Oct 11, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@jonsimantov jonsimantov merged commit b50057e into main Oct 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@firebase firebase locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @sunmou99