Skip to content

Install Firebase tools locally, and skip if unneeded in desktop tests. #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Nov 2, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

npm -g is failing on Windows due to file access issues. Instead, install npm packages locally and add the local module paths to the system PATH.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration test in this PR, tests on all 3 platforms.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit 91efa2a
Last updated: Thu Nov 2 15:53 PDT 2023
View integration test log & download artifacts

Failures Configs
analytics [BUILD] [ERROR] [iOS] [macos]
app_check [BUILD] [ERROR] [iOS] [macos]
[BUILD] [ERROR] [tvOS] [macos]
auth [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
database [BUILD] [ERROR] [tvOS] [macos]
firestore [BUILD] [ERROR] [iOS] [macos]
[BUILD] [ERROR] [tvOS] [macos]
[TEST] [ERROR] [Android] [2/3 os: ubuntu windows] [1/2 android_device: android_target]
functions [BUILD] [ERROR] [tvOS] [macos]
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdViewLoadAd
installations [BUILD] [ERROR] [iOS] [macos]
remote_config [BUILD] [ERROR] [tvOS] [macos]
[TEST] [ERROR] [Android] [1/3 os: windows] [1/2 android_device: android_target]
storage [BUILD] [ERROR] [iOS] [macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 2, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Nov 2, 2023
@jonsimantov jonsimantov marked this pull request as ready for review November 2, 2023 19:27
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Nov 2, 2023
@jonsimantov jonsimantov requested a review from a-maurice November 2, 2023 19:27
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 2, 2023
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 2, 2023
@jonsimantov jonsimantov merged commit 91efa2a into main Nov 2, 2023
@jonsimantov jonsimantov deleted the fix-npm-windows branch November 2, 2023 20:15
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Nov 2, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 2, 2023
@firebase firebase locked and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants