Skip to content

Update Android dependencies to BoM 32.7.0. #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Dec 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 12, 2023
Copy link

github-actions bot commented Dec 12, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit 51ee094
Last updated: Tue Dec 12 18:25 PST 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Linux] [x64] [openssl]
[TEST] [ERROR] [MacOS] [x64] [openssl]
[TEST] [ERROR] [Windows] [x64] [openssl]
app_check [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
gma [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov changed the title Update Android dependencies to 32.7.0. Update Android dependencies to BoM 32.7.0. Dec 12, 2023
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2023
@jonsimantov jonsimantov merged commit 51ee094 into try-gma-with-upgraded-gradle Dec 12, 2023
@jonsimantov jonsimantov deleted the update-bom-32.7.0 branch December 12, 2023 22:40
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2023
jonsimantov added a commit that referenced this pull request Dec 13, 2023
…K version, and including GMA (#1473)

* Update Android dependencies - Tue Oct 10 2023

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/6475704829) by [firebase-android-sdk Oct 10 release](firebase/firebase-android-sdk@a135c51).

  ### Android

- com.google.android.gms.play_services_ads → 22.4.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6475709960).

* Build GMA with Android 31.

* Increment all gradle wrapper versions to 6.7.1.

* Fix quote in classpath.

* Update all gradle plugin versions to 4.2.1.

* Force NDK path to environment variable for new Gradle version.

* Update build tools version.

* Add gradle.properties with useAndroidX=true flag.

* Remove NDK path from unneeded gradle files.

* Force name of included C++ SDK build to be firebase_cpp_sdk.

This fixes a breaking change in Gradle 6 where included builds
no longer have their name propagated, but instead they use
their path (unless you explicitly set the name, as in this change).

* Update Firestore internal test also.

* Add gradle.properties files.

* Update readme with new version.

* Add cleanup directory.

* Add to .gitignore.

* Add changed .externalNativeBuild --> .cxx directory to script
and ProGuard rules.

* Revert "Add cleanup directory."

This reverts commit ec1e046.

* Add cleanup directory (again).

* Project tweaks to build on Android SDK 33, required for GMA.

* Update Android dependencies - Thu Oct 19 2023 (#1481)

* Update Android dependencies - Thu Oct 19 2023

### Android

- com.google.firebase.firebase_bom → 32.4.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/6580059572).

* Enable multidex.

---------

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: Jon Simantov <jsimantov@google.com>

* Update to 32.4.1 bom.

* Update readme.

* Update Android dependencies to 32.7.0. (#1498)

---------

Co-authored-by: firebase-workflow-trigger-bot <firebase-workflow-trigger-bot@google.com>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant