Skip to content

Switch to node 18, node 16 no longer works with Firebase CLI. #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Dec 12, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Firebase CLI (and Firestore emulator) now require Node 18 minimum, so install that on our runners instead of 16.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Tests in this PR, this should also fix the Firestore desktop nightlies.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2023
Copy link

github-actions bot commented Dec 12, 2023

❌  Integration test FAILED

Requested by @jonsimantov on commit cd5c493
Last updated: Tue Dec 12 16:45 PST 2023
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [Android] [2/3 os: ubuntu windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(6 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
gma [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [FLAKINESS] [Android] [2/3 os: ubuntu macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Dec 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 12, 2023
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Dec 12, 2023
@jonsimantov jonsimantov enabled auto-merge (squash) December 12, 2023 21:42
@jonsimantov jonsimantov merged commit cd5c493 into main Dec 12, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 13, 2023
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants