Skip to content

UMP iOS: Add extra locks around async operations. #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2024
Merged

UMP iOS: Add extra locks around async operations. #1517

merged 3 commits into from
Jan 12, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 12, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Also fix the "Wrong Instance" test to be simpler and handle non-UI mode.

This should fix one of the most common test flakes in this repo.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jan 12, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit ba0b681
Last updated: Fri Jan 12 16:18 PST 2024
View integration test log & download artifacts

@jonsimantov jonsimantov changed the title Add extra locks around async operations. UMP iOS: Add extra locks around async operations. Jan 12, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 12, 2024
@jonsimantov jonsimantov marked this pull request as ready for review January 12, 2024 21:48
@jonsimantov jonsimantov force-pushed the fix-ump-callbacks-test branch from 2705890 to bd34935 Compare January 12, 2024 22:15
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 12, 2024
@jonsimantov jonsimantov enabled auto-merge (squash) January 12, 2024 22:52
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 12, 2024
@jonsimantov jonsimantov merged commit ba0b681 into main Jan 12, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 13, 2024
@firebase firebase locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @cynthiajoan