Use an older version of binutils on Mac #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
commented
Dec 7, 2020
| @@ -67,8 +65,12 @@ jobs: | |||
| include: | |||
| - os: ubuntu-latest | |||
| tools_platform: linux | |||
| # Binutils 2.35.1 released Sep 19, 2020 | |||
| binutils_version: "2.35.1" | |||
There was a problem hiding this comment.
Note: I've learned you can't use env substitution in matrix definitions, so I had to move the version numbers directly into here.
a-maurice
previously approved these changes
Dec 7, 2020
a-maurice
approved these changes
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest binutils causes blastdoor to create invalid Mac libraries that crash the linker. Until this is fixed in binutils, use an older version that is known to work.
Because this older version does not support thread-local storage on Mac, disable thread-local storage in our usage of websockets via a define at build time. This does not cause a problem because we only use websockets via the Firebase scheduler, which runs all websockets requests in a single worker thread.