Fixed issue with integration tests finding google-services.json #246
+26
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-maurice
previously approved these changes
Jan 22, 2021
jonsimantov
previously approved these changes
Jan 25, 2021
alexames
force-pushed
the
feature/full_path_for_google_services
branch
from
c1f6342 to
07b167e
Compare
Changed the search paths for the google-services.json file in CMakeLists.txt files to use full paths instead of relative paths. According to the CMake documentation, the `if (EXISTS ...)` condition is only well defined for full paths. This might work on some platforms but it failed in my tests on Windows.
alexames
force-pushed
the
feature/full_path_for_google_services
branch
from
9769270 to
c7d527e
Compare
a-maurice
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the search paths for the google-services.json file in
CMakeLists.txt files to use full paths instead of relative paths.
According to the CMake documentation, the
if (EXISTS ...)condition isonly well defined for full paths. This might work on some platforms but
it failed in my tests on Windows.