Deprecate the STLPort support #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
reviewed
Apr 12, 2021
release_build_files/readme.md
Outdated
| @@ -571,13 +571,10 @@ code. | |||
|
|
|||
| ## Release Notes | |||
|
|
|||
| ### 7.3.0 | |||
| ### 7.2.0 | |||
| - Changes | |||
| - General (Android): the STLPort support is deprecated and will be removed | |||
| in the next major release. Please [use libc++ instead](https://developer.android.com/ndk/guides/cpp-support#cs). | |||
There was a problem hiding this comment.
"Support for the STLPort STL variant is deprecated..."
Also wrap to 80 (put the link on the next line)?
There was a problem hiding this comment.
Or just copy the warning text exactly, I like that.
There was a problem hiding this comment.
Or just copy the warning text exactly, I like that.
Done.
Put the whole URL on the next line -- I'm not sure if splitting the markdown element in two could break the formatting?
There was a problem hiding this comment.
I was thinking wrapping it like this:
- General (Android): the STLPort support is deprecated and will be removed
in the next major release. Please
use libc++ instead.
jonsimantov
suggested changes
Apr 12, 2021
release_build_files/readme.md
Outdated
| @@ -571,13 +571,10 @@ code. | |||
|
|
|||
| ## Release Notes | |||
|
|
|||
| ### 7.3.0 | |||
| ### 7.2.0 | |||
| - Changes | |||
| - General (Android): the STLPort support is deprecated and will be removed | |||
| in the next major release. Please [use libc++ instead](https://developer.android.com/ndk/guides/cpp-support#cs). | |||
There was a problem hiding this comment.
Or just copy the warning text exactly, I like that.
jonsimantov
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.