Skip to content

Remove the deprecated SDK Instance ID #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2021
Merged

Remove the deprecated SDK Instance ID #399

merged 2 commits into from
Apr 28, 2021

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Apr 28, 2021 •
edited
Loading

Remove the Deprecated Instance ID SDK sources and update build files.

@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Apr 28, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 28, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 28, 2021
@DellaBitta DellaBitta added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Apr 28, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 28, 2021
@github-actions
Copy link

github-actions bot commented Apr 28, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @DellaBitta on commit d2596d2
Last updated: Wed Apr 28 15:52:22 PDT 2021
View integration test results

@DellaBitta DellaBitta marked this pull request as ready for review April 28, 2021 20:50
@DellaBitta DellaBitta requested a review from cynthiajoan April 28, 2021 20:50
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 28, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 28, 2021
@DellaBitta DellaBitta merged commit 7d6d8c9 into main Apr 28, 2021
@DellaBitta DellaBitta deleted the feature/ddb_remove_instanceid branch April 28, 2021 23:40
@firebase firebase locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @cynthiajoan