Skip to content

Fix release build notes formatting #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 30, 2021
Merged

Fix release build notes formatting #401

merged 14 commits into from
Apr 30, 2021

Conversation

ehsannas
Copy link
Contributor

Fix the table formatting for release_build_files/readme.

See original vs. new.

@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@ehsannas ehsannas requested a review from vimanyu April 29, 2021 14:40
@vimanyu vimanyu requested a review from jonsimantov April 29, 2021 17:46
vimanyu
vimanyu reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and fixing it.
Could you change the PR title to a more descriptive one, maybe "Fix release build notes formatting"?
LGTM otherwise. Will approve once the merge conflict is resolved.

@ehsannas ehsannas changed the title Ehsannas patch 1 Fix release build notes formatting Apr 30, 2021
@ehsannas ehsannas requested a review from vimanyu April 30, 2021 15:49
@ehsannas
Copy link
Contributor Author

@vimanyu Ah sorry didn't notice the title. It was decided automatically by the GitHub UI 😄 PTAL

vimanyu
vimanyu approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas enabled auto-merge (squash) April 30, 2021 19:46
@ehsannas ehsannas merged commit 3c8f78f into firebase:main Apr 30, 2021
@ehsannas ehsannas self-assigned this May 4, 2021
@vimanyu vimanyu mentioned this pull request May 11, 2021
Merged
@firebase firebase locked and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vimanyu vimanyu vimanyu approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees

@ehsannas ehsannas

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @vimanyu