Skip to content

Remove the Deprecated Remote Config Impl #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 30, 2021
Merged

Remove the Deprecated Remote Config Impl #402

merged 4 commits into from
Apr 30, 2021

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Apr 30, 2021 •
edited
Loading

Changes:

  • Removed the Remote Config static API.
  • Update the integration test to remove deprecated API tests.
  • Added readme.md notes. Additionally added notes for the Instance ID removal.
  • Ran the quick Integration Tests for sanity.

@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@DellaBitta DellaBitta changed the title Removed the Deprecated Implementation of Remote Config Remove the Deprecated Implementation of Remote Config Apr 30, 2021
@DellaBitta DellaBitta changed the title Remove the Deprecated Implementation of Remote Config Remove the Deprecated Remote Config Impl Apr 30, 2021
@DellaBitta DellaBitta marked this pull request as ready for review April 30, 2021 17:32
@DellaBitta DellaBitta added the tests-requested: quick Trigger a quick set of integration tests. label Apr 30, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 30, 2021
@github-actions
Copy link

github-actions bot commented Apr 30, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @DellaBitta on commit 5dd20b7
Last updated: Fri Apr 30 11:12:30 PDT 2021
View integration test results

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 30, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 30, 2021
@DellaBitta DellaBitta merged commit c27ba1d into main Apr 30, 2021
@firebase firebase locked and limited conversation to collaborators May 31, 2021
@DellaBitta DellaBitta deleted the feature/remove_deprecated_remoteconfig branch June 26, 2021 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @cynthiajoan