-
Notifications
You must be signed in to change notification settings - Fork 125
Rationalize C++ source layout #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have broken the PR down to smaller contained commits that can be reviewed. The last commit is just the result of running the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of points:
grep
still shows a few mentions of _ios
(including those in comments):
$ grep -RI _ios firestore
./integration_test_internal/src/field_value_test.cc:#include "firestore/src/ios/field_value_ios.h"
./integration_test_internal/src/util/integration_test_util.cc:#include "firestore/src/ios/firestore_ios.h"
./integration_test_internal/src/firestore_test.cc: // Also, the logic in `util_ios.h` can be modified to make sure that
./src/android/field_value_android.h: // these constructors must match the equivalents in field_value_ios.h.
(omitting some irrelevant stuff)
I would urge you to import this change before merging it (I think Copybara should be able to handle an unmerged branch) and doing all the necessary changes to the BUILD
files, just in case it uncovers any issues with this PR.
Consider reverting the formatting changes, they increase the delta without being directly related to the theme of this PR. I'd prefer to have those committed via a separate PR.
9507062
to
18fd68a
Compare
(1) Uh, that's a great catch! Thanks. I have addressed things that were found via grep. Done. |
I got a successful import (a few minor changes were needed to internal files) via cl/377574378 |
✅ Integration test succeeded!Requested by @ehsannas on commit cdb07c1 |
The integration test failures seemed random/flakey 😢 (and different tests were failing on different platforms). I've restarted the GitHub Actions... |
Integration tests passed 👍 |
See b/174877213 for details and doc.