Skip to content

Feature/tvos cleanup integration tests #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 24, 2021
Merged

Feature/tvos cleanup integration tests #487

merged 12 commits into from
Jun 24, 2021

Conversation

vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Jun 23, 2021 •
edited
Loading

Tons of cleanup on tvos integration test setup. Retaining only the bare minimum required to setup the XCode projects.

  • Removed any user specific directories for XCode across the repo (xcuserdata). Added this to .gitignore too.
  • Removed .xcworkspace as it is created automatically on pod install
  • Removed Pods sub project and linker reference to pod libraries in xcode project. These are automatically done on pod install too.
  • Removed "Assets" and "plist" file for tvos target. Aside from getting rid of unncessary files, we also get rid of deeply nested directories under Assets folder which caused errors while checkout out the repo on Windows (260 character limit for paths)
  • Sharing the same plist file for ios and tvos targets. This is more convenient for running simulation tests on CI as our existing infrastructure for iOS for post processing Info.plist files should just work for tvos too.
  • Setting tvOS deployment target to 10.1 to include older devices in our tests.

To test,
Since this PR mostly involves xcode files, the best way to check would be to try out any of the integration tests locally.

  • Get GoogleService-Info.plist
  • python3 setup_integration_tests.py
  • cd <firebase_product>/integration_test
  • pod install
  • open integration_test.xcworkspace
  • Drag and drop xcframeworks. Prebuilt ones can be obtained from this run
  • Build and run integration_test_tvos

vimanyu added 12 commits June 22, 2021 16:50
@vimanyu
cleaning up storage tvos integration test
07bb73b 
Removed xcworkspace
Removed Assets icons and images resources
Sharing a single plist file between ios and tvos
@vimanyu
removing reference to tvos plist file
d4bcef9
@vimanyu
git ignore xcode user specific directories
7e6c182
@vimanyu
cleanup remote_config tvos integration test
d512500 
removed user specific directories
removed references to tvos specific assets and plist file
sharing ios plist files for tvos
@vimanyu
tvos deployment version set to 10.1
1696154
@vimanyu
storage tvos deployment target set to 10.1
9b07050
@vimanyu
cleanup functions tvos integration test
2b07fae 
removed workspace directory
removed tvos specific assets and plist file
sharing ios plist file with tvos target
deployment target set to 10.1
@vimanyu
cleanup firestore internal integration tests for tvos
162e6f4 
removed workspace directory
removed tvos specific assets and plist file
sharing ios plist file with tvos target
set tvos deployment target to 10.1
@vimanyu
cleanup firestore integration test for tvos
1de37e1 
removed workspace directory
removed tvos specific assets and plist file
sharing ios plist file with tvos target
set tvos deployment target to 10.1
@vimanyu
cleanup database integration test for tvos
4a9eba5 
added Google-ServiceInfo.plist to Copy Bundle files
added frameworks
removed tvos specific assets and plist file
sharing ios plist file with tvos target
set tvos deployment target to 10.1
@vimanyu
cleanup auth integration test for tvos
7ada573 
removed tvos specific assets and plist file
sharing ios plist file with tvos target
set tvos deployment target to 10.1
cleaned up header path in ios target
cleaned up Pods project and refs in xcodeproj
@vimanyu
cleaning things that are added on pod install
24d7d9d 
Running pod install will add these to the xcode project anyway.
It doesnt make sense to have them in the xcode project before that.
@vimanyu vimanyu requested review from DellaBitta and sunmou99 June 23, 2021 01:39
@vimanyu vimanyu self-assigned this Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jun 23, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2021
@github-actions
Copy link

github-actions bot commented Jun 23, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @vimanyu on commit 7d0c987
Last updated: Thu Jun 24 13:54 PDT 2021
View integration test log & download artifacts

Failures Configs
installations [TEST] [FAILURE] [Android] [windows] [android_latest]
(1 failed tests)  TestGettingTokenTwiceMatches
messaging [TEST] [ERROR] [Android] [macos] [android_latest]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 23, 2021
sunmou99
sunmou99 approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@sunmou99 sunmou99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Manually with iOS+tvOS XCFramework.
LGTM

@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2021
@vimanyu vimanyu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 23, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Jun 24, 2021
@vimanyu vimanyu merged commit 7d0c987 into main Jun 24, 2021
@vimanyu vimanyu deleted the feature/tvos-cleanup-integration-tests branch June 24, 2021 18:39
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@sunmou99 sunmou99 removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 24, 2021
@firebase firebase locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunmou99 sunmou99 sunmou99 approved these changes

@DellaBitta DellaBitta Awaiting requested review from DellaBitta

Assignees

@vimanyu vimanyu

Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimanyu @sunmou99