Skip to content

Clean up flaky tests a bit by adding std::function support to RunWithRetry/RunFlakyBlock. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 15, 2021
Merged

Clean up flaky tests a bit by adding std::function support to RunWithRetry/RunFlakyBlock. #534

merged 14 commits into from
Jul 15, 2021

Conversation

jonsimantov
Copy link
Contributor

By adding std::function overloads to the flaky retry functions (possible now that stlport is removed), we can clean up a lot of code that uses RunFlakyBlock and RunWithRetry.

Refactor flaky test handling in Storage to use RunWithRetry instead of RunFlakyBlock where possible - it's much cleaner.

Also add some flaky test handling in Auth and Analytics.

@google-cla google-cla bot added the cla: yes label Jul 13, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 13, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 13, 2021
@github-actions
Copy link

github-actions bot commented Jul 13, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit 0010b72
Last updated: Wed Jul 14 23:29 PDT 2021
View integration test log & download artifacts

@jonsimantov jonsimantov requested a review from alexames July 14, 2021 00:08
alexames
alexames suggested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@alexames alexames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions, feel free to file bugs and defer either one

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 14, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2021
@jonsimantov jonsimantov requested a review from alexames July 14, 2021 17:47
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 14, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jul 14, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 14, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 14, 2021
alexames
alexames previously approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@alexames alexames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonsimantov jonsimantov enabled auto-merge (squash) July 14, 2021 22:08
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jul 14, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Jul 14, 2021
@jonsimantov jonsimantov requested a review from alexames July 14, 2021 22:09
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 15, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 15, 2021
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Jul 15, 2021
@jonsimantov jonsimantov merged commit 0010b72 into main Jul 15, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels Jul 15, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 15, 2021
@jonsimantov jonsimantov deleted the feature/flaky-test-cleanup branch July 17, 2021 00:48
@firebase firebase locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@alexames alexames alexames approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @alexames