Fix detection of which tests to run when "quick" tests are requested. #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
changed the title
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @jonsimantov on commit 26054b4 |
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
jonsimantov
added
the
tests-requested: quick
github-actions
bot
removed
the
tests-requested: quick
sunmou99
reviewed
Jul 14, 2021
sunmou99
reviewed
Jul 14, 2021
sunmou99
reviewed
Jul 14, 2021
sunmou99
reviewed
Jul 14, 2021
github-actions
bot
added
tests: failed
sunmou99
approved these changes
Jul 15, 2021
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: failed
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Merging anyway, as it's a flake. Failure log: |
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code was attempting to auto-diff with ${{github.event.pull_request.base.sha}}.
As it turns out, this is incorrect - the base sha in this case points to the current head of main, not the head of main when the branch was created (which is closer to what we want).
Instead, we now do the actual correct thing: query git to find the common ancestor commit of origin/main and origin/[pr branch name], and diff the PR's branch (again from origin) against that common ancestor.
This makes it much more robust to detect which files were actually edited by a PR, even if the base main branch has since been modified (and even if those modifications were partially merged into this branch).
Also in this PR: change to print_matrix_configuration to allow us to treat certain files as being within a given subdirectory when looking through the file list in auto-diff mode. For example, cmake/external/firestore.cmake should be considered under the "firestore" directory.