Clean up all flaky tests to be much more straightforward. #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This touches some internal googletest stuff, so it may break in the future if we update to a later googletest version. Rather than using this directly, you should use the following two macros: FLAKY_TEST_SECTION_BEGIN(); FLAKY_TEST_SECTION_END(); This change also cleans up existing tests to use this new method.
jonsimantov
added
the
tests-requested: quick
DellaBitta
previously approved these changes
Jul 15, 2021
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit f6d1bee
|
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
alexames
approved these changes
Jul 15, 2021
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
tests: in-progress
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RunFlakyTestSection, which lets you use regular EXPECT macros.
(This touches some internal googletest stuff, so it may break in the future if we update to a later googletest version.)
Rather than using RunFlakyTestSection directly, you should use the following two macros:
FLAKY_TEST_SECTION_BEGIN();
FLAKY_TEST_SECTION_END();
This PR also cleans up existing tests to use this new method.