Remove the deprecated RunTransaction function #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsannas
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @ehsannas on commit 5c1a935
|
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
var-const
suggested changes
Jul 15, 2021
| } // namespace firestore | ||
| } // namespace firebase | ||
|
|
||
| #endif // FIREBASE_FIRESTORE_SRC_COMMON_TRANSACTION_FUNCTION_H_ |
|
the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| * @return Either Error::kErrorOk if successful or the error code from Error | ||
| * that most closely matches the failure. | ||
| */ | ||
| virtual Error Apply(Transaction& transaction, std::string& error_message) = 0; |
There was a problem hiding this comment.
Is this a non-const reference? If so, make const or use a pointer: Transaction& transaction
| * @return Either Error::kErrorOk if successful or the error code from Error | ||
| * that most closely matches the failure. | ||
| */ | ||
| virtual Error Apply(Transaction& transaction, std::string& error_message) = 0; |
There was a problem hiding this comment.
Is this a non-const reference? If so, make const or use a pointer: std::string& error_message
var-const
approved these changes
Jul 19, 2021
github-actions
bot
added
the
tests: in-progress
github-actions
bot
added
tests: failed
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.