Ensure that argv specified to googletest has a null terminator. #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @dconeybe on commit ba9d52e |
jonsimantov
reviewed
Jul 20, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
var-const
previously approved these changes
Jul 20, 2021
| @@ -309,13 +309,17 @@ std::vector<std::string> ArgcArgvToVector(int argc, char* argv[]) { | |||
|
|
|||
| char** VectorToArgcArgv(const std::vector<std::string>& args_vector, | |||
| int* argc) { | |||
| char** argv = new char*[args_vector.size()]; | |||
| // Create `argv` one element larger than strictly required since gtest expects | |||
There was a problem hiding this comment.
IIUC, this is a POSIX requirement -- if so, it should probably be mentioned in this comment (otherwise, it reads as if it's a requirement imposed by Googletest).
…googletest filters to modified_args
var-const
approved these changes
Jul 21, 2021
github-actions
bot
added
tests: in-progress
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://man7.org/linux/man-pages/man2/execve.2.html,
However, it appears that the
argvspecified tocommon_main()is not terminated in this way, at least on Android. This causes googletest'sParseGoogleTestFlagsOnly()function to read past the end ofargv.https://github.com/google/googletest/blob/8d51ffdfab10b3fba636ae69bc03da4b54f8c235/googletest/src/gtest.cc#L6634-L6649
This doesn't usually lead to issues; however, when run with Address Sanitizer this causes a crash since it is technically referencing unallocated memory.
This PR works around this by explicitly adding a null terminator to
argv.Googlers can see b/192351260#comment11 for more details.