Skip to content

Fix bug in dependency update workflow. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 29, 2021
Merged

Fix bug in dependency update workflow. #685

merged 8 commits into from
Sep 29, 2021

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Sep 28, 2021

Description

Provide details of the change, and generalize the change in the PR title above.

Fix a bug in the Python script that outputs the logfile of dependency changes. Also make the workflow script a little more robust in the case where the logfile doesn't exist or is malformed (it should still create the PR, just without the details in the description).


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/1284791796


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Sep 28, 2021
@jonsimantov jonsimantov enabled auto-merge (squash) September 28, 2021 20:22
@jonsimantov jonsimantov enabled auto-merge (squash) September 29, 2021 00:11
@jonsimantov jonsimantov merged commit 9e702bf into main Sep 29, 2021
@jonsimantov jonsimantov deleted the bugfix/dep-update branch September 29, 2021 00:20
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Sep 29, 2021
@github-actions
Copy link

github-actions bot commented Sep 29, 2021

❌  Integration test FAILED

Requested by @jonsimantov on commit 9e702bf
Last updated: Tue Sep 28 19:54 PDT 2021
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Android] [macos]
analytics [BUILD] [ERROR] [Android] [macos]
auth [BUILD] [ERROR] [Android] [macos]
functions [BUILD] [ERROR] [Android] [macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Sep 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Sep 29, 2021
@firebase firebase locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants