Quick check uses dummy google-services file, and skip certain tests #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove restore_secret.py
sunmou99
changed the title
sunmou99
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -603,6 +610,7 @@ TEST_F(FirebaseFirestoreBasicTest, TestRunTransaction) { | |||
| // TODO: Add test for failing transaction. | |||
There was a problem hiding this comment.
Missing username in TODO; it should look like "// TODO(my_username): Stuff."
There was a problem hiding this comment.
Will firestore team resolve the TODO?
There was a problem hiding this comment.
That is a pre-existing TODO, unrelated to this PR. And, yes, it would be Firestore's to fix.
| @@ -665,6 +673,7 @@ TEST_F(FirebaseFirestoreBasicTest, | |||
| } | |||
|
|
|||
| TEST_F(FirebaseFirestoreBasicTest, TestInvalidatingReferencesWhenDeletingApp) { | |||
| SKIP_TEST_ON_QUICK_CHECK; | |||
| delete shared_app_; | |||
| shared_app_ = nullptr; | |||
| // TODO: Ensure existing Firestore objects are invalidated. | |||
There was a problem hiding this comment.
Missing username in TODO; it should look like "// TODO(my_username): Stuff."
dconeybe
approved these changes
Oct 25, 2021
github-actions
bot
added
the
tests: in-progress
❌ Integration test FAILEDRequested by @sunmou99 on commit 3990d4c
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
External contributors failed the quick check and cannot merge their PR, because they don't have access to the SECRET.
Now, remove the SECRET logic in all pre-submit check.
Add dummy google-services file as a placeholder to make sure the testapp still build.
Also skip tests that requires SECRET.
Type of Change
Place an
xthe applicable box: