Skip to content

Update iOS dependencies - Fri Oct 29 2021 #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2021
Merged

Update iOS dependencies - Fri Oct 29 2021 #714

merged 4 commits into from
Nov 1, 2021

Conversation

firebase-workflow-trigger[bot]
Copy link
Contributor

@firebase-workflow-trigger firebase-workflow-trigger bot commented Oct 29, 2021 •
edited by jonsimantov
Loading

iOS

  • Firebase/Analytics → 8.9.0
  • Firebase/Auth → 8.9.0
  • Firebase/Core → 8.9.0
  • Firebase/Crashlytics → 8.9.0
  • Firebase/Database → 8.9.0
  • Firebase/DynamicLinks → 8.9.0
  • Firebase/Firestore → 8.9.0
  • Firebase/Functions → 8.9.0
  • Firebase/Installations → 8.9.0
  • Firebase/Messaging → 8.9.0
  • Firebase/RemoteConfig → 8.9.0
  • Firebase/Storage → 8.9.0

Created by Update Android and iOS dependencies workflow.

Also includes modified version requirement in integration test Podfiles (tvOS 10.0 → 12.0), and Firestore iOS fixes for breaking changes due to App Check.

Update iOS dependencies - Fri Oct 29 2021
71165cb 
### iOS

- Firebase/Analytics → 8.9.0
- Firebase/Auth → 8.9.0
- Firebase/Core → 8.9.0
- Firebase/Crashlytics → 8.9.0
- Firebase/Database → 8.9.0
- Firebase/DynamicLinks → 8.9.0
- Firebase/Firestore → 8.9.0
- Firebase/Functions → 8.9.0
- Firebase/Installations → 8.9.0
- Firebase/Messaging → 8.9.0
- Firebase/RemoteConfig → 8.9.0
- Firebase/Storage → 8.9.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1399963409).
@firebase-workflow-trigger firebase-workflow-trigger bot added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 29, 2021
@jonsimantov
Copy link
Contributor

@dconeybe It looks like Cocoapods was only half-updated when the previous PR was generated. This one should have the complete update. I'll add a fix to prevent this race condition in the future.

@jonsimantov jonsimantov mentioned this pull request Oct 29, 2021
Closed
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 29, 2021
@dconeybe
Copy link
Contributor

I've pushed up commit 9cf40da, which should fix the Firestore build issues.

@jonsimantov
Copy link
Contributor

jonsimantov commented Oct 29, 2021 •
edited
Loading

FYI the race condition in the iOS SDK update should now be fixed here, for future releases: firebase/firebase-ios-sdk#8887.

I'll take a look at the other build issues.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 29, 2021
@jonsimantov
Copy link
Contributor

Something odd is still definitely happening with the Cocoapods versions. It'll require further investigation.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 29, 2021
@jonsimantov
Copy link
Contributor

Looks like it's an issue with the minimum tvOS version - bumping it up in a few Podfiles, this should fix the issues.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 29, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@github-actions github-actions bot removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 29, 2021
@jonsimantov
Copy link
Contributor

Now it's failing because GitHub is returning http status code 429 (too many requests) to our GitHub runners. 😐

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 29, 2021
@github-actions
Copy link

github-actions bot commented Oct 29, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 4f1d245
Last updated: Mon Nov 1 13:14 PDT 2021
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [macos] [All android_device]
auth [TEST] [FAILURE] [Android] [windows] [emulator_target]
(2 failed tests)  FirebaseAuthTest.TestSendPasswordResetEmail
  FirebaseAuthTest.TestSignInWithBadCredentials
firestore [TEST] [ERROR] [Android] [windows] [android_target]
[TEST] [FAILURE] [Android] [ubuntu] [android_target]
(1 failed tests)  QueryTest.TestCanQueryByDocumentId

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov
Copy link
Contributor

I have a different draft PR where I've worked around the issue -- there's an Android Firestore build error:

https://github.com/firebase/firebase-cpp-sdk/runs/4051671512?check_suite_focus=true

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 29, 2021
@dconeybe
Copy link
Contributor

I just pushed up 6f198bd which should fix the Android build error. I didn't test it locally so fingers are crossed.

@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 30, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Oct 30, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Oct 30, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 30, 2021
@dconeybe
Copy link
Contributor

dconeybe commented Nov 1, 2021

Looks like the integration tests failed to build for admob in build-desktop-macos-latest-openssl and FirebaseMessagingTest.TestReceiveToken failed in test-android-macos-latest-android_target. Notably, Firestore looks good.

@jonsimantov
Copy link
Contributor

Looks like the integration tests failed to build for admob in build-desktop-macos-latest-openssl and FirebaseMessagingTest.TestReceiveToken failed in test-android-macos-latest-android_target. Notably, Firestore looks good.

Yep - I think the build issue will be fixed by #717, and the token issue is a known flake. Let's merge this!

@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Nov 1, 2021
@jonsimantov jonsimantov enabled auto-merge (squash) November 1, 2021 17:24
@jonsimantov jonsimantov self-requested a review November 1, 2021 17:28
@jonsimantov jonsimantov merged commit 4f1d245 into main Nov 1, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 1, 2021
@jonsimantov jonsimantov deleted the workflow/auto-update-deps-65-20211029-172841 branch November 1, 2021 18:32
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 1, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 1, 2021
@dconeybe dconeybe mentioned this pull request Nov 2, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @dconeybe