-
Notifications
You must be signed in to change notification settings - Fork 125
Update iOS dependencies - Tue Apr 12 2022 #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iOS dependencies - Tue Apr 12 2022 #893
Conversation
[Triggered](https://github.com/firebase/firebase-ios-sdk/actions/runs/2157136735) by [firebase-ios-sdk refs/tags/v8.15.0 release](https://github.com/firebase/firebase-ios-sdk/releases/tag/refs/tags/v8.15.0). ### iOS - Firebase/Analytics → 8.14.0 - Firebase/Auth → 8.14.0 - Firebase/Core → 8.14.0 - Firebase/Crashlytics → 8.14.0 - Firebase/Database → 8.14.0 - Firebase/DynamicLinks → 8.14.0 - Firebase/Firestore → 8.14.0 - Firebase/Functions → 8.14.0 - Firebase/Installations → 8.14.0 - Firebase/Messaging → 8.14.0 - Firebase/RemoteConfig → 8.14.0 - Firebase/Storage → 8.14.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2157137959).
✅ Integration test succeeded!Requested by @firebase-workflow-trigger[bot] on commit 989781b |
@dconeybe Because of the custom Firestore iOS SDK external package version, it didn't get updated automatically here. Should we update it to the 8.14.0 Cocoapods tag? |
What do you mean by "custom Firestore iOS SDK external package version"? |
@jonsimantov Are you referring to this line:
|
Ah my mistake - for some reason I thought it was failing to update due to a custom version. So it should be changed to CocoaPods-8.14.0, right? |
Yes, that version should definitely be updated. Good catch! Is the reason that it was missed because the way that the version was specified was changed from
to
? If yes, I can definitely change it back. |
No need to change it back - but we should fix update-dependencies.yml (line 81) to change the updated line. |
I think I'll change it back actually. There was no need for it to change and the original line is more consistent with other cmake files for external projects. (Update: here is the PR: #899).
Also, maybe (in a separate PR) the |
Triggered by firebase-ios-sdk refs/tags/v8.15.0 release.
iOS