Skip to content

Update iOS dependencies - Tue Apr 12 2022 #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

firebase-workflow-trigger[bot]
Copy link
Contributor

Triggered by firebase-ios-sdk refs/tags/v8.15.0 release.

iOS

  • Firebase/Analytics → 8.14.0
  • Firebase/Auth → 8.14.0
  • Firebase/Core → 8.14.0
  • Firebase/Crashlytics → 8.14.0
  • Firebase/Database → 8.14.0
  • Firebase/DynamicLinks → 8.14.0
  • Firebase/Firestore → 8.14.0
  • Firebase/Functions → 8.14.0
  • Firebase/Installations → 8.14.0
  • Firebase/Messaging → 8.14.0
  • Firebase/RemoteConfig → 8.14.0
  • Firebase/Storage → 8.14.0

Created by Update Android and iOS dependencies workflow.

[Triggered](https://github.com/firebase/firebase-ios-sdk/actions/runs/2157136735) by [firebase-ios-sdk refs/tags/v8.15.0 release](https://github.com/firebase/firebase-ios-sdk/releases/tag/refs/tags/v8.15.0).

  ### iOS

- Firebase/Analytics → 8.14.0
- Firebase/Auth → 8.14.0
- Firebase/Core → 8.14.0
- Firebase/Crashlytics → 8.14.0
- Firebase/Database → 8.14.0
- Firebase/DynamicLinks → 8.14.0
- Firebase/Firestore → 8.14.0
- Firebase/Functions → 8.14.0
- Firebase/Installations → 8.14.0
- Firebase/Messaging → 8.14.0
- Firebase/RemoteConfig → 8.14.0
- Firebase/Storage → 8.14.0

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2157137959).
@firebase-workflow-trigger firebase-workflow-trigger bot added the tests-requested: quick Trigger a quick set of integration tests. label Apr 12, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 12, 2022
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

✅  Integration test succeeded!

Requested by @firebase-workflow-trigger[bot] on commit 989781b
Last updated: Tue Apr 12 14:49 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 12, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 12, 2022
@jonsimantov
Copy link
Contributor

@dconeybe Because of the custom Firestore iOS SDK external package version, it didn't get updated automatically here. Should we update it to the 8.14.0 Cocoapods tag?

@dconeybe
Copy link
Contributor

custom Firestore iOS SDK external package version

What do you mean by "custom Firestore iOS SDK external package version"?

@dconeybe
Copy link
Contributor

@jonsimantov Are you referring to this line:

GetReleasedDep("CocoaPods-8.12.1")

@jonsimantov
Copy link
Contributor

@jonsimantov Are you referring to this line:

GetReleasedDep("CocoaPods-8.12.1")

Ah my mistake - for some reason I thought it was failing to update due to a custom version.

So it should be changed to CocoaPods-8.14.0, right?

@dconeybe
Copy link
Contributor

So it should be changed to CocoaPods-8.14.0, right?

Yes, that version should definitely be updated. Good catch!

Is the reason that it was missed because the way that the version was specified was changed from

set(version CocoaPods-8.12.1)

to

GetReleasedDep("CocoaPods-8.12.1")

?

If yes, I can definitely change it back.

@jonsimantov
Copy link
Contributor

So it should be changed to CocoaPods-8.14.0, right?

Yes, that version should definitely be updated. Good catch!

Is the reason that it was missed because the way that the version was specified was changed from

set(version CocoaPods-8.12.1)

to

GetReleasedDep("CocoaPods-8.12.1")

?

If yes, I can definitely change it back.

No need to change it back - but we should fix update-dependencies.yml (line 81) to change the updated line.

@dconeybe
Copy link
Contributor

dconeybe commented Apr 14, 2022

No need to change it back - but we should fix update-dependencies.yml (line 81) to change the updated line.

I think I'll change it back actually. There was no need for it to change and the original line is more consistent with other cmake files for external projects. (Update: here is the PR: #899).

sed -i~ "s/^set(version [^)]*)/set(version CocoaPods-${firestore_version})/i" cmake/external/firestore.cmake

Also, maybe (in a separate PR) the sed command should be tweaked to fail if it doesn't find a match. That would raise the visibility of this issue. Here is an example I found via a quick internet search: https://stackoverflow.com/questions/15965073/return-value-of-sed-for-no-match.

@dconeybe dconeybe assigned jonsimantov and unassigned dconeybe Apr 14, 2022
@firebase firebase locked and limited conversation to collaborators May 19, 2022
@a-maurice a-maurice deleted the workflow/auto-update-deps-100-20220412-192943 branch August 31, 2022 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants