Skip to content

Update simulator min version #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

Update simulator min version #936

merged 3 commits into from
May 9, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented May 7, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

iOS 12.4 simulator is not playing nicely with Xcode 13.3.1. Update to use iOS 13.7 instead to unbreak the tests. We still test on iOS 12.x on FTL so this is low risk.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Can only be tested in the expanded matrix.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label May 7, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) May 7, 2022 07:38
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 7, 2022
@github-actions
Copy link

github-actions bot commented May 7, 2022 •
edited
Loading

⏳  Integration test in progress...

Requested by @jonsimantov on commit 0644119
Last updated: Mon May 9 11:08 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels May 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 7, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 8, 2022
@jonsimantov jonsimantov requested a review from sunmou99 May 9, 2022 05:55
@jonsimantov jonsimantov requested a review from a-maurice May 9, 2022 17:26
@jonsimantov jonsimantov assigned a-maurice and sunmou99 and unassigned sunmou99 May 9, 2022
@jonsimantov jonsimantov merged commit 0644119 into main May 9, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels May 9, 2022
@jonsimantov jonsimantov removed the tests: in-progress This PR's integration tests are in progress. label May 9, 2022
@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

@sunmou99 sunmou99 Awaiting requested review from sunmou99

Assignees

@a-maurice a-maurice

@sunmou99 sunmou99

Labels
skip-release-notes Skip release notes check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsimantov @a-maurice @sunmou99