Skip to content

Fix handler typo in billing alerts #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Fix handler typo in billing alerts #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7de5ff2
fixing typo
colerogers Feb 21, 2022
16e8e12
changing var name & fixing describe title
colerogers Feb 21, 2022
2b11e22
Merge remote-tracking branch 'origin/master' into colerogers.fix-bill…
colerogers Mar 4, 2022
affd78b
updating alerttype
colerogers Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spec/v2/providers/alerts/billing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,25 +43,25 @@ describe('billing', () => {
});
});

describe('onAutomatedPlanUpdatePublished', () => {
describe('onPlanAutomatedUpdatePublished', () => {
it('should create a function with only handler', () => {
const func = billing.onAutomatedPlanUpdatePublished(myHandler);
const func = billing.onPlanAutomatedUpdatePublished(myHandler);

expect(func.__endpoint).to.deep.equal({
platform: 'gcfv2',
labels: {},
eventTrigger: {
eventType: alerts.eventType,
eventFilters: {
alertType: billing.automatedPlanUpdateAlert,
alertType: billing.planAutomatedUpdateAlert,
},
retry: false,
},
});
});

it('should create a function with opts & handler', () => {
const func = billing.onAutomatedPlanUpdatePublished(
const func = billing.onPlanAutomatedUpdatePublished(
{ ...FULL_OPTIONS },
myHandler
);
Expand All @@ -71,7 +71,7 @@ describe('billing', () => {
eventTrigger: {
eventType: alerts.eventType,
eventFilters: {
alertType: billing.automatedPlanUpdateAlert,
alertType: billing.planAutomatedUpdateAlert,
},
retry: false,
},
Expand Down
10 changes: 5 additions & 5 deletions src/v2/providers/alerts/billing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export type BillingEvent<T> = CloudEvent<FirebaseAlertData<T>, WithAlertType>;
/** @internal */
export const planUpdateAlert = 'billing.planUpdate';
/** @internal */
export const automatedPlanUpdateAlert = 'billing.automatedPlanUpdate';
export const planAutomatedUpdateAlert = 'billing.planAutomatedUpdate';

/**
* Declares a function that can handle a billing plan update event.
Expand Down Expand Up @@ -60,18 +60,18 @@ export function onPlanUpdatePublished(
/**
* Declares a function that can handle an automated billing plan update event.
*/
export function onAutomatedPlanUpdatePublished(
export function onPlanAutomatedUpdatePublished(
handler: (
event: BillingEvent<PlanAutomatedUpdatePayload>
) => any | Promise<any>
): CloudFunction<FirebaseAlertData<PlanAutomatedUpdatePayload>>;
export function onAutomatedPlanUpdatePublished(
export function onPlanAutomatedUpdatePublished(
opts: options.EventHandlerOptions,
handler: (
event: BillingEvent<PlanAutomatedUpdatePayload>
) => any | Promise<any>
): CloudFunction<FirebaseAlertData<PlanAutomatedUpdatePayload>>;
export function onAutomatedPlanUpdatePublished(
export function onPlanAutomatedUpdatePublished(
optsOrHandler:
| options.EventHandlerOptions
| ((event: BillingEvent<PlanAutomatedUpdatePayload>) => any | Promise<any>),
Expand All @@ -80,7 +80,7 @@ export function onAutomatedPlanUpdatePublished(
) => any | Promise<any>
): CloudFunction<FirebaseAlertData<PlanAutomatedUpdatePayload>> {
return onOperation<PlanAutomatedUpdatePayload>(
automatedPlanUpdateAlert,
planAutomatedUpdateAlert,
optsOrHandler,
handler
);
Expand Down