-
Notifications
You must be signed in to change notification settings - Fork 217
Migrate endpoint annotation eventTrigger.eventFilters to list of filters #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like we both made a similar set of changes #1047 |
@colerogers D'oh can't believe I missed that! Do you want to update your PR with some of the other minor changes I've made or use this one instead? I didn't look too closely, but it looks like it's mostly char-by-char the same change. |
@taeold We can just use yours! But I found a small issue when I changed the alerts providers, the attributes should not have been camel cased. If you can just yank all the files from |
@colerogers Nice! Updated the PR. |
@@ -1,0 +1 @@ | |||
- Add support for more regions and memory for v2 functions (#1037). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a changelog entry for this PR too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose not to since this change is refactoring non-user facing APIs. Let me know if you disagree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the empty src/common/manifest.ts?
}); | ||
}); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inlined It's actually deleted: https://github.com/firebase/firebase-functions/tree/dl-cf3v2-eventfitlers/src/common I'm not sure why Github PR displays it as an empty file 🤔 |
Previously,
eventFilter
attribute was an object:We now prefer eventFilter as a list:
Most of the change in this PR is in tests. Few other minor changes I've squeezed in here: