Further improve on config() type #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
approved these changes
Nov 30, 2017
Byeol
pushed a commit
to Byeol/firebase-functions
that referenced
this pull request
Jan 9, 2018
The backend team is still working on event payload changes, so this just helps them tests with an `Event<any>` implementation. It is very intentional that this is not exposed in index.ts; alpha testers will manually reach into lib/providers/datastore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further addition to #127. Updates
config().firebaseto be strictly of typefirebase.AppOptionsinstead of the union withundefinedsinceconfig()will throw an error ifmerged.firebaseis undefined. This keeps from unnecessarily having to check whetherfirebaseexists or not.