Skip to content

Add required types to Functions SDK #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2019
Merged

Add required types to Functions SDK #465

merged 3 commits into from
Jun 12, 2019

Conversation

thechenky
Copy link
Contributor

Description

Adds back the required types that were moved to devDependencies previously.

@thechenky thechenky requested review from bkendall and kevinajian June 12, 2019 23:23
bkendall
bkendall approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this manually via npm pack and npm install in a freshly-init'd function. 👍

@thechenky thechenky merged commit e1c6129 into master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

@kevinajian kevinajian Awaiting requested review from kevinajian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thechenky @bkendall