Skip to content

Add entry for maxInstances #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2020
Merged

Add entry for maxInstances #636

merged 3 commits into from
Mar 19, 2020

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Mar 19, 2020 •
edited
Loading

Adds CHANGELOG entry for #624.

Sample (#624)

import * as functions from 'firebase-functions'
functions
    .runWith({ maxInstances: 1 })

@joehan joehan requested a review from laurenzlong March 19, 2020 20:50
laurenzlong
laurenzlong suggested changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a quick code sample, also link to the PR.

@joehan
Copy link
Contributor Author

joehan commented Mar 19, 2020

Done - the PR is linked too, Github is just collapsing the full link to #624

@joehan joehan requested a review from laurenzlong March 19, 2020 22:04
@joehan joehan merged commit 9e05b7f into master Mar 19, 2020
joehan added a commit that referenced this pull request Mar 19, 2020
@joehan
Revert "Add entry for maxInstances (#636)"
f1e80f6 
This reverts commit 9e05b7f.
@joehan
Copy link
Contributor Author

joehan commented Mar 19, 2020

AHHHH I didn't mean to merge this in without a review, I have too many Github tabs open :(

@joehan joehan deleted the jh-changelog branch January 19, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurenzlong laurenzlong Awaiting requested review from laurenzlong

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joehan @laurenzlong @googlebot