Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies when logging. Fixes #737 #844

Merged
merged 6 commits into from Jan 15, 2021
Merged

Conversation

huangjeff5
Copy link
Contributor

@huangjeff5 huangjeff5 commented Jan 13, 2021

Description

This PR removes circular dependencies so that they do not cause strange output in the logs.

@huangjeff5 huangjeff5 changed the base branch from master to mb-circ January 14, 2021 02:12
@google-cla
Copy link

google-cla bot commented Jan 15, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jan 15, 2021
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@huangjeff5 huangjeff5 changed the base branch from mb-circ to master January 15, 2021 00:05
@huangjeff5
Copy link
Contributor Author

@mbleigh Heads up, this is the same as your old PR, except two changes:

  • It looks like there was a small bug when binding the loggers: 8e08474
  • Modify removeCircular to return a new object rather than mutate the original.

I created a new one because I don't have permission to push commits to the old PR.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants