-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Firebase App Check One-time Use Tokens for Callable Functions SDK #11270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
bb8df26
draft pr for callable functions
aiwenisevan 1e9b989
Adjust Functions podspec dependency on AppCheckInterop
ncooke3 3fc0cce
Add 'HTTPSCallableOptions' class
ncooke3 aa7d457
Re-implement with new HTTPSCallableOptions type
ncooke3 893f74e
Revert and update Objective-C API tests
ncooke3 765534d
Mark new AppCheckInterop API optional for backwards compatibility
ncooke3 ad5d68b
Preserve existing codable Functions API
ncooke3 67a49df
Revert integration tests
ncooke3 846eb22
Style
ncooke3 ad16f94
Fix some test build breakages
ncooke3 02e8bdf
Add changelog entry
ncooke3 c813e82
Style
ncooke3 2cb3a62
Fix AppCheck tests
ncooke3 a41565e
Cleanup current approach
ncooke3 e326a97
Re-organize tests
ncooke3 f5114ac
Add 'options' param to 'getContext' call
ncooke3 73d1e6c
Add success case unit test
ncooke3 5d7f00a
Shorten expectation waiting timeout
ncooke3 c67a730
Add remaining unit tests
ncooke3 6df2641
Amend current test
ncooke3 144068d
Rename 'limitedUseTokens' to 'requireLimitedUseTokens'
ncooke3 621c80a
Fix build and tests
ncooke3 8b9d19a
Fix some renaming misses
ncooke3 2e038c1
Fix some renaming misses (1)
ncooke3 09183c1
Update FirebaseFunctions/CHANGELOG.md
ncooke3 e304a1a
Update FirebaseFunctions/Sources/Functions.swift
ncooke3 7391807
Update FirebaseFunctions/Sources/Functions.swift
ncooke3 6b91923
Update FirebaseFunctions/Sources/Functions.swift
ncooke3 d5ef755
Update FirebaseFunctions/Sources/Functions.swift
ncooke3 16baf44
Update FirebaseFunctions/Sources/HTTPSCallableOptions.swift
ncooke3 e30f75d
[App Check] Always return fresh limitedUseToken (#11298)
andrewheard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2023 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
import Foundation | ||
|
||
/// Configuration options for a ``HTTPSCallable`` instance. | ||
@objc(FIRHTTPSCallableOptions) public class HTTPSCallableOptions: NSObject { | ||
/// Whether or not to protect the callable function with a limited-use App Check token. | ||
@objc public let requireLimitedUseAppCheckTokens: Bool | ||
|
||
/// Designated intializer. | ||
/// - Parameter requireLimitedUseAppCheckTokens: A boolean used to decide whether or not to | ||
/// protect the callable function with a limited use App Check token. | ||
@objc public init(requireLimitedUseAppCheckTokens: Bool) { | ||
self.requireLimitedUseAppCheckTokens = requireLimitedUseAppCheckTokens | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.