Skip to content

[Infra] Remove 18.3.1 sim workaround #15206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

[Infra] Remove 18.3.1 sim workaround #15206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bca20c
[Infra] Remove 18.3.1 sim workaround
ncooke3 Aug 15, 2025
41aa0b5
Update build.sh
ncooke3 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,12 +492,11 @@ case "$product-$platform-$method" in
../../../FirebaseRemoteConfig/Tests/Swift/AccessToken.json

# Integration tests are only run on iOS to minimize flake failures.
# TODO(ncooke3): Remove -sdk and -destination flags and replace with "${xcb_flags[@]}"
RunXcodebuild \
-workspace 'gen/FirebaseRemoteConfig/FirebaseRemoteConfig.xcworkspace' \
-scheme "FirebaseRemoteConfig-Unit-swift-api-tests" \
-sdk 'iphonesimulator' \
-destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' \
"${ios_flags[@]}" \
"${xcb_flags[@]}" \
build \
test
;;
Expand Down Expand Up @@ -575,12 +574,10 @@ case "$product-$platform-$method" in

if check_secrets; then
# Integration tests are only run on iOS to minimize flake failures.
# TODO(ncooke3): Add back "${ios_flags[@]}". See #14657.
RunXcodebuild \
-workspace 'gen/FirebaseStorage/FirebaseStorage.xcworkspace' \
-scheme "FirebaseStorage-Unit-integration" \
-sdk 'iphonesimulator' \
-destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' \
"${ios_flags[@]}" \
"${xcb_flags[@]}" \
test
fi
Expand All @@ -596,12 +593,10 @@ case "$product-$platform-$method" in

if check_secrets; then
# Integration tests are only run on iOS to minimize flake failures.
# TODO(ncooke3): Add back "${ios_flags[@]}". See #14657.
RunXcodebuild \
-workspace 'gen/FirebaseStorage/FirebaseStorage.xcworkspace' \
-scheme "FirebaseStorage-Unit-ObjCIntegration" \
-sdk 'iphonesimulator' \
-destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' \
"${ios_flags[@]}" \
"${xcb_flags[@]}" \
test
fi
Expand All @@ -620,8 +615,8 @@ case "$product-$platform-$method" in
RunXcodebuild \
-workspace 'gen/FirebaseCombineSwift/FirebaseCombineSwift.xcworkspace' \
-scheme "FirebaseCombineSwift-Unit-integration" \
-sdk 'iphonesimulator' \
-destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' \
"${ios_flags[@]}" \
"${xcb_flags[@]}" \
test
fi
;;
Expand Down
Loading