Skip to content

getByte into the actual buffer, not into the byte array struct #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2020
Merged

getByte into the actual buffer, not into the byte array struct #5227

merged 1 commit into from
Mar 30, 2020

Conversation

mikehaney24
Copy link
Contributor

Also:

  • add a test, confirmed failing without these changes
  • rename variable to better represent what it is

@mikehaney24
getByte into the actual buffer, not into the byte array struct
faf6c5c 
Also:
- add a test, confirmed failing without these changes
- rename variable to better represent what it is
@mikehaney24 mikehaney24 merged commit 1f55b92 into master Mar 30, 2020
@mikehaney24 mikehaney24 deleted the mph-fixmorestupid branch March 30, 2020 19:55
pranavrajgopal pushed a commit that referenced this pull request Apr 8, 2020
@mikehaney24 @pranavrajgopal
getByte into the actual buffer, not into the byte array struct (#5227)
2a47387 
Also:
- add a test, confirmed failing without these changes
- rename variable to better represent what it is
ryanwilson pushed a commit that referenced this pull request Apr 24, 2020
@mikehaney24 @ryanwilson
getByte into the actual buffer, not into the byte array struct (#5227)
1728c48 
Also:
- add a test, confirmed failing without these changes
- rename variable to better represent what it is
@firebase firebase locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maksymmalyhin maksymmalyhin Awaiting requested review from maksymmalyhin

@paulb777 paulb777 Awaiting requested review from paulb777

@samedson samedson Awaiting requested review from samedson

@doudounan doudounan Awaiting requested review from doudounan

1 more reviewer

@jasonhu-g jasonhu-g jasonhu-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes GoogleDataTransport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikehaney24 @jasonhu-g @googlebot @google-oss-bot