Skip to content

Fix InstanceID cron build regression #5468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2020
Merged

Fix InstanceID cron build regression #5468

merged 2 commits into from
Apr 27, 2020

Conversation

paulb777
Copy link
Member

#5301 broke the InstanceID cron tests that depended on the dash not being in the switch.

See https://travis-ci.org/github/firebase/firebase-ios-sdk/jobs/680094682

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested a review from charlotteliang April 27, 2020 14:52
@paulb777 paulb777 merged commit 629c2ae into master Apr 27, 2020
@paulb777 paulb777 deleted the ci-fixes branch April 27, 2020 17:54
@firebase firebase locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees

No one assigned

Labels

api: instanceid cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulb777 @google-oss-bot @charlotteliang @googlebot