FIS backoff adjustments and tests #6230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maksymmalyhin
commented
Aug 7, 2020
maksymmalyhin
commented
- 403 - unrecoverable
- 401 and 404 - no backoff as they are auto-recoverable by the SDK
- connection errors - no backoff
- 429, 5xx - maximum backoff interval 30 min
- tests
maksymmalyhin
requested review from
paulb777,
andirayo,
ankitaj224 and
charlotteliang
Generated by 🚫 Danger |
charlotteliang
approved these changes
Aug 7, 2020
paulb777
approved these changes
Aug 7, 2020
maksymmalyhin
added a commit
that referenced
this pull request
Aug 10, 2020
* FirebaseInstallations: API requests backoff (#6207) * FIRInstallationsBackoffController introduced * FIRCurrentDateProvider introduced * FIRInstallationsBackoffControllerTests * style * FIRInstallationsBackoffController implementation * WIP: tests * Response to backoff event mapping * FIRInstallationsIDController: integration with FIRInstallationsBackoffController * Remove not existing error code. * FIRInstallationsIDController: integration with FIRInstallationsBackoffController * FIRInstallationsIDController: depend on FIRInstallationsBackoffControllerProtocol * FIRInstallationsIDControllerTests: supplement tests with backoff validation * TODOs * TODO * API docs * Header import fixed * FIS backoff adjustments and tests (#6230) * Maximum backoff interval 30 min * Errors adjusted * Tests updated * Exclude 401 and 404 from backoff as autorecoverable * comments * FIS 1.6.0 changelog (#6234) * Change log version fixed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.