Merge Release 4.10.1 into Master #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes b/74357976 which caused unauthenticated users to be unable to reach the Firestore backend and updates the changelog.
This fixes a known instances of memory corruption where in FSTLevelDBMutationQueue, the NSString view was retained for later, and the incorrect user was used, causing b/74381054. gRPC does not necessarily copy its string argumnets and if our hostname were configured to a non-default one it's possible that we could corrupt the host cache too. All remaining usages of util::WrapNSStringNoCopy are obviously safe: passed into logging or other known transient usages.
|
Should not be merged until release is public |
|
Right: we're just working through the merge conflicts here so that we can release when ready. The fixes on 4.10.1 don't apply to master cleanly. |
|
Ack. Will wait for the release go public. (Actually travis got this already: CocoaPods could not find compatible versions for pod "Firebase/Core": In Podfile: Firebase/Core (= 4.10.1)) =D |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
paulb777
approved these changes
Mar 9, 2018
mikelehen
reviewed
Mar 9, 2018
| @@ -319,7 +319,8 @@ - (void)invokeRPCWithFactory:(GRPCProtoCall * (^)(void))rpcFactory | |||
| [FSTDatastore | |||
| prepareHeadersForRPC:rpc | |||
| databaseID:&self.databaseInfo->database_id() | |||
| token:(result.is_valid() ? result.token() : absl::string_view())]; | |||
| token:(result.user().is_authenticated() ? result.token() | |||
| : absl::string_view())]; | |||
There was a problem hiding this comment.
FYI- I think this needs to be clang-formatted. I noticed it in my original commit, but if you clang-format, it reindents this whole block causing a bigger diff, so I didn't bother. But once you merge this into mater, perhaps we should immediately follow up with a clang-format fixup PR or something.
There was a problem hiding this comment.
Oh! Actually I see you have a "fix lint" commit in here, so maybe you already took care of the issue. If so, ignore me.
Merged
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman@google.com> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman@google.com> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman@google.com> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman@google.com> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu@google.com> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman@google.com> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg@google.com> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien@google.com> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien@google.com> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu@google.com> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu@google.com> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman@google.com> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang@google.com> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman@google.com> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu@google.com> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman@google.com> ORIGINAL_AUTHOR=Gil <wilhuff@github.com> PiperOrigin-RevId: 188809445
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman@google.com> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman@google.com> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman@google.com> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman@google.com> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu@google.com> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman@google.com> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg@google.com> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien@google.com> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien@google.com> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu@google.com> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu@google.com> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman@google.com> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang@google.com> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman@google.com> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu@google.com> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman@google.com> PiperOrigin-RevId: 188809445
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman@google.com> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman@google.com> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman@google.com> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman@google.com> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu@google.com> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman@google.com> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg@google.com> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien@google.com> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien@google.com> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu@google.com> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu@google.com> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman@google.com> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang@google.com> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman@google.com> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu@google.com> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman@google.com> ORIGINAL_AUTHOR=Gil <wilhuff@github.com> PiperOrigin-RevId: 188809445
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman> ORIGINAL_AUTHOR=Gil <wilhuff@github.com> PiperOrigin-RevId: 188809445
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman> ORIGINAL_AUTHOR=Gil <wilhuff@github.com> PiperOrigin-RevId: 188809445
zxu123
pushed a commit
to zxu123/firebase-ios-sdk
that referenced
this pull request
May 23, 2018
-- 197713382 by zxu <zxu>: Implement more on listener class and implement ListenerRegistration. TESTED: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/testapp:android_testapp_test --config=android_x86 --define firebase_build=stable blaze test //sensored/cpp:firestore_kokoro blaze test //sensored/cpp:listener_registration_test -- 196551381 by zxu <zxu>: Implement more on listener class and implement the DocumentReference::AddSnapshotListener. Also added a few test case and fixed a bug in DocumentReferenceInternal. ListenerRegistration will be implemented in subsequent CL. TESTED: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/testapp:android_testapp_test --config=android_x86 --define firebase_build=stable blaze test //sensored/cpp:firestore_kokoro blaze test //sensored/cpp:firestore_test -- 196276752 by zxu <zxu>: Implement the SnapshotMetadata with inline methods and (non-)Wrapper for Firestore C++. TESTED: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/testapp:android_testapp_test --config=android_x86 --experimental_one_version_enforcement=warning blaze test //sensored/cpp:firestore_kokoro blaze test //sensored/cpp:firestore_test -- 195841793 by zxu <zxu>: Implement the wrapper class for callback (EventListener). People unlike huge CL. So sending this short one for review. In subsequent CLs, I'll do: * cache/uncache or the CppEventListener class and the wiring of native method; * actually using this to implement DocumentReference::AddSnapshotListener; * update the testapp to run android_test with callback. -- 194112388 by zxu <zxu>: Add Android-Wrapper for DocumentReference's non-callback methods. Tested: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/cpp:firestore_kokoro blaze test //sensored/cpp:firestore_test -- 192445183 by zxu <zxu>: Add Android-Wrapper for Firestore's remaining methods. Tested: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/cpp:firestore_kokoro blaze test //sensored/cpp:firestore_test -- 190986604 by mcg <mcg>: Manually import the public portion of - 22c226a C++ migration: make Timestamp class a part of public API ... by Konstantin Varlamov <var-const@users.noreply.github.com> Note that this only imports the header, which otherewise won't come over with a regular copybara run because we're currently excluding the public headers from the Firestore import with cl/188810622. The .cc implementation of this will come over with a regular copybara import, coming shortly. -- 189013767 by zxu <zxu>: Add Android-Wrapper for Firestore's method that does not involve other Firestore types. Tested: blaze test //sensored/testapp:testapp_build_test blaze test //sensored/testapp:testapp_build_test --config=android_x86 blaze test //sensored/cpp:firestore_kokoro -- 188809445 by mcg <mcg>: Import of firebase-ios-sdk from Github. - 07f4695 Updates Changelog for 4.5.0 release (firebase#908) by Zsika Phillip <protocol86@users.noreply.github.com> - 2b82a2e Allow serializing arbitrary length FieldValues (firebase#889) by rsgowman <rgowman> - 3e41f25 Fix test failures that occur during prod build (firebase#910) by rsgowman <rgowman> - f122cf7 Fix MutationQueue issue resulting in re-sending acknowled... by Michael Lehenbauer <mikelehen@gmail.com> - 7522314 Partial wrapping of pb_ostream_t (pt2) (firebase#903) by rsgowman <rgowman> - 0d3adb1 Partial wrapping of pb_ostream_t (pt1) (firebase#899) by rsgowman <rgowman> - e41f4b1 Merge Release 4.10.1 into Master (firebase#896) by zxu <zxu> - 2ae36f1 [De]Serialize FieldValue map_values ("Objects") (firebase#878) by rsgowman <rgowman> - 5930ad2 Factor out a universal build script (firebase#884) by Gil <mcg> - 8ef0f14 Adds Email link sign-in (firebase#882) by Paul Beusterien <paulbeusterien> - 0b8f216 Merge pull request firebase#880 from firebase/release-4.10.0 by Paul Beusterien <paulbeusterien> - 8311c64 port paths to FSTDocumentKey (firebase#877) by zxu <zxu> - 34ebf10 Add 10 second timeout waiting for connection before clien... by Michael Lehenbauer <mikelehen@gmail.com> - 1c40e7a add converters and port paths to FSTQuery (firebase#869) by zxu <zxu> - 9b5b4d8 Serialize (and deserialize) string values (firebase#864) by rsgowman <rgowman> - c6f73f7 Fix the issue completion handler is not triggered in subs... by Chen Liang <chliang> - 1ecf690 Add FieldValue.boolean_value() (firebase#862) by rsgowman <rgowman> - 3e7c062 replacing Auth by C++ auth implementation (firebase#802) by zxu <zxu> - 13aeb61 Eliminate TypedValue and serialize direct from FieldValue... by rsgowman <rgowman> -- 187049498 by mcg <mcg>: Import of firebase-ios-sdk from Github. - f7d9f29 Fix lint warnings (firebase#840) by Gil <mcg> - b5c60ad Refactor [En|De]codeVarint to be symetric wrt tags (firebase#837) by rsgowman <rgowman> - ddc12c0 Merge pull request firebase#694 from morganchen12/auth-docs by Morgan Chen <morganchen12@gmail.com> - 442d46f Avoid warnings about failing to override a designated ini... by Gil <mcg> - 4dc63f8 Fix Firestore tests for M22 (firebase#834) by Gil <mcg> - 935f3ca Avoid wrapping and rewrapping NSStrings when constructin... by Gil <mcg> - 6ce954a Serialize (and deserialize) int64 values (firebase#818) (firebase#829) by rsgowman <rgowman> - 41dcd4b Fix trivial mem leak in the test suite (firebase#828) by rsgowman <rgowman> - 50f9df9 Accept FIRTimestamp where NSDate is currently accepted as... by Konstantin Varlamov <var-const@users.noreply.github.com> - 67b068e Fix implicit retain self warnings (firebase#808) by rsgowman <rgowman> - 14ea068 Make FSTTimestamp into a public Firestore class (firebase#698) by Konstantin Varlamov <var-const@users.noreply.github.com> - de00de2 [En|De]codeUnsignedVarint -> [En|De]codeVarint (firebase#817) by rsgowman <rgowman> - 9bf73ab Fix two stream close issues (b/73167987, b/73382103). (firebase#8... by Michael Lehenbauer <mikelehen@gmail.com> - 7a4a2ea replacing FSTGetTokenResult by C++ Token implementation (... by zxu <zxu> - a9f3f35 Delete stale Firestore instances after FIRApp is deleted.... by Ryan Wilson <wilsonryan> - aa6f1ae Disable -Wrange-loop-analysis for abseil (firebase#807) by rsgowman <rgowman> - ef55eef Require official 1.4.0 for min CocoaPods version (firebase#806) by Paul Beusterien <paulbeusterien> - 7cddb97 Serialize (and deserialize) bool values (firebase#791) by rsgowman <rgowman> - 7a97f6c Enable -Wcomma for our build; disable it for abseil. (firebase#799) by rsgowman <rgowman> - 81ee594 DispatchQueue delayed callback improvements + testing (firebase#7... by Michael Lehenbauer <mikelehen@gmail.com> - fd9fd27 replacing Auth/FSTUser by C++ auth implementation (firebase#804) by zxu <zxu> - 6889850 Merge pull request firebase#801 from firebase/release-4.9.0 by Paul Beusterien <paulbeusterien> - e4be254 Fixed capitalization of init in test function. (firebase#797) by Ryan Wilson <wilsonryan> - 933be73 Improve documentation on auto-init property in FCM. (firebase#792) by Chen Liang <chliang> - 0f3c24b Actually ignore events on inactive streams, rather than j... by Greg Soltis <gsoltis> - fe19fca Serialize and deserialize null (firebase#783) by rsgowman <rgowman> - 95d0411 fix flaky test (firebase#788) by zxu <zxu> - b6613bd Cleaning up implicit retain for the RTDB and Storage by Sebastian Schmidt <mrschmidt> - 5f5f808 Keep track of number of queries in the query cache (firebase#776) by Greg Soltis <gsoltis> - c7c51a7 Fix double parsing on 32 bit devices. (firebase#787) by Ryan Wilson <wilsonryan> - 9504582 Port Firestore Document to C++ (firebase#777) by zxu <zxu> - adf9fb3 Update FieldValue of type Reference (firebase#775) by zxu <zxu> - 4afcfb1 Move to explicit nil check. (firebase#782) by Ryan Wilson <wilsonryan> - fd83e07 Strawman C++ API (firebase#763) by rsgowman <rgowman> - 8003348 C++ port: add C++ equivalent of FSTDocumentKey. (firebase#762) by Konstantin Varlamov <var-const@users.noreply.github.com> - 612d99c Fix Core CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF warnings (#... by Paul Beusterien <paulbeusterien> - bf45a15 port Firestore SnapshotVersion in C++ (firebase#767) by zxu <zxu> - d70c23e port Firestore Auth module in C++ (firebase#733) by zxu <zxu> - 633eb7b Let Travis run for `CMake` test and `lint.sh` (firebase#769) by zxu <zxu> - 274fe52 cmake build fixes (firebase#770) by rsgowman <rgowman> -- 184568931 by mcg <mcg>: Import of firebase-ios-sdk from Github. - 32266c5 Make sure Firestore/core/include is in the podspec (firebase#748) by Gil <mcg> - 070c0ea Merge pull request firebase#746 from morganchen12/unguarded-block by Morgan Chen <morganchen12@gmail.com> - 13f572e Increase expectation timeout to 25 seconds. (firebase#744) by Michael Lehenbauer <mikelehen@gmail.com> - 47d81fd fix (firebase#739) by Chen Liang <chliang> - 515625c Remove predecessorKey,Object,Document, etc (firebase#735) by Gil <mcg> - ac30522 Start on ArraySortedMap in C++ (firebase#721) by Gil <mcg> - 729b8d1 Move all Firestore Objective-C to Objective-C++ (firebase#734) by Gil <mcg> - 693d064 Merge pull request firebase#732 from OleksiyA/FCM-subscribe-compl... by Oleksiy Ivanov <oleksiy@informationrd.com> - 3cbdbf2 Schema migrations for LevelDB (firebase#728) by Greg Soltis <gsoltis> - 6474a82 Firestore DatabaseId in C++ (firebase#727) by zxu <zxu> - 05ef5ae Add absl_strings to firebase_firestore_util_test dependen... by rsgowman <rgowman> - 03a0069 Add changelog entry for my last PR (oops) and also add a ... by Michael Lehenbauer <mikelehen@gmail.com> - 5a280ca Import iterator_adaptors from google3 (firebase#718) by Gil <mcg> - 63a380b Use fixed-sized types (firebase#719) by Gil <mcg> - 6dc1373 Version updates to 4.8.2 (firebase#722) by Paul Beusterien <paulbeusterien> - a74d39f Fix a number of c++ build errors (firebase#715) by rsgowman <rgowman> - cceeec3 travis: check for copyright in sources (firebase#717) by Paul Beusterien <paulbeusterien> - 4d7c973 Fix b/72502745: OnlineState changes cause limbo document ... by Michael Lehenbauer <mikelehen@gmail.com> - af6976a normalize and port the rest of Firebase/Port code (firebase#713) by zxu <zxu> - 7226b4a port TargetIdGenerator to iOS (firebase#709) by zxu <zxu> - 5306474 adding unit test for auto init enable function (firebase#710) by Chen Liang <chliang> - 821fb90 implement `TargetIdGenerator` in C++ for Firestore (firebase#701) by zxu <zxu> - 5fdda3f normalize string_util (firebase#708) by zxu <zxu> - 15a2926 Update CHANGELOG for M21.1 release (firebase#679) by Ryan Wilson <wilsonryan> - f027214 Fix incorrect deprecation message (firebase#688) by Iulian Onofrei <6d0847b9@opayq.com> - bfa0e40 Implement the rest of FieldValue types for C++ (firebase#687) by zxu <zxu> - 1f77212 Properly publish Abseil sources as a part of the podspec ... by Gil <mcg> ORIGINAL_AUTHOR=Firebase <firebase-noreply> PiperOrigin-RevId: 197713382
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Version bumps for Firebase 4.10.1 (firebase#891) * Minimal fix for b/74357976 (firebase#890) Fixes b/74357976 which caused unauthenticated users to be unable to reach the Firestore backend and updates the changelog. * Copy all C++ strings to NSString where they're not obviously safe (firebase#893) This fixes a known instances of memory corruption where in FSTLevelDBMutationQueue, the NSString view was retained for later, and the incorrect user was used, causing b/74381054. gRPC does not necessarily copy its string argumnets and if our hostname were configured to a non-default one it's possible that we could corrupt the host cache too. All remaining usages of util::WrapNSStringNoCopy are obviously safe: passed into logging or other known transient usages. * fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.