Skip to content

Remove url label. add Codable test #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Remove url label. add Codable test #9667

merged 2 commits into from
Apr 20, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Apr 19, 2022

Per offline discussions

@inlined inlined requested a review from ryanwilson April 19, 2022 22:14
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

ryanwilson
ryanwilson reviewed Apr 20, 2022
View reviewed changes
@ryanwilson ryanwilson merged commit 694059f into master Apr 20, 2022
@ryanwilson ryanwilson deleted the inlined.httpsCallableNoLabel branch April 20, 2022 00:57
@ryanwilson ryanwilson added this to the Firebase 9 milestone Apr 20, 2022
@firebase firebase locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

api: functions

Projects

None yet

Milestone

Firebase 9

Development

Successfully merging this pull request may close these issues.

4 participants

@inlined @google-oss-bot @paulb777 @ryanwilson