Skip to content

Fix a bug with limitToLast and cursors #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix a bug with limitToLast and cursors #9675

merged 1 commit into from
Apr 20, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 20, 2022

No description provided.

@wu-hui wu-hui requested a review from cherylEnkidu April 20, 2022 15:52
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

cherylEnkidu
cherylEnkidu approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your fix!

@cherylEnkidu cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Apr 20, 2022
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 86.78% (2eefff0) to 86.75% (49f250a) by -0.03%.

    FilenameBase (2eefff0)Merge (49f250a)Diff
    exception.cc73.68%23.68%-50.00%
    exception_apple.mm58.62%89.66%+31.03%
    leveldb_key.cc98.17%98.38%+0.22%
    ordered_code.cc94.15%93.41%-0.73%
    query.cc96.77%98.39%+1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ekYV2sPz8r.html

@wu-hui wu-hui merged commit 939f131 into master Apr 20, 2022
@wu-hui wu-hui deleted the wuandy/LimitToLastCursors branch April 20, 2022 17:07
@paulb777 paulb777 added this to the Firebase 9 milestone Apr 20, 2022
@paulb777
Copy link
Member

Added to 9.0.0 release candidate

@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@wu-hui wu-hui

Labels

api: firestore

Projects

None yet

Milestone

Firebase 9

Development

Successfully merging this pull request may close these issues.

4 participants

@wu-hui @google-oss-bot @paulb777 @cherylEnkidu