Skip to content

Commit

Permalink
Fix webchannel wrapper overrides (#7593)
Browse files Browse the repository at this point in the history
* Fix webchannel wrapper overrides

* Create fresh-frogs-heal.md

* Update fresh-frogs-heal.md

* Update fresh-frogs-heal.md
  • Loading branch information
wu-hui authored Aug 29, 2023
1 parent 25cda8a commit 60e4a07
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .changeset/fresh-frogs-heal.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@firebase/firestore": patch
"@firebase/webchannel-wrapper": patch
---

Fix an issue where Firestore was incorrectly using XHR instead of fetch for streaming response.
3 changes: 3 additions & 0 deletions packages/webchannel-wrapper/externs/overrides.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ goog.net.WebChannel.Options.forceLongPolling;
/** @type {boolean|undefined} */
goog.net.WebChannel.Options.detectBufferingProxy;

/** @type {boolean|undefined} */
goog.net.WebChannel.Options.useFetchStreams;

/** @type {unknown} */
goog.net.WebChannel.Options.xmlHttpFactory;

Expand Down

0 comments on commit 60e4a07

Please sign in to comment.