Fix for issue where firestore could not be loaded alongside firebase.js #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
previously approved these changes
Oct 9, 2017
|
CI Issue... I may have to do this a little differently |
jshcrowthe
force-pushed
the
concat-module-fix
branch
from
8c64652 to
a719761
Compare
|
I notice that packages/firebase/firebase.js is now 4MB instead of 400k, although firebase.js.gz is still small (it seems that firebase.js inlines the source map). Is that expected? If packages/firebase/firebase.js is what gets served on the CDN, then 4MB is a problem. :-) |
|
WHOA! I forgot a path on the sourcemaps. THank you thank you thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where
firebase-firestore.jscould not be loaded alongsidefirebase.js