Skip to content

Avoid "private" getter _databaseId, since it breaks the minified build. #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Avoid "private" getter _databaseId, since it breaks the minified build. #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef0390
Avoid "private" getter _databaseId, since it breaks the minified build.
Oct 9, 2017
1f5f3cf
[AUTOMATED]: Prettier Code Styling
Oct 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/firestore/src/api/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,8 @@ class FirestoreConfig {
* The root reference to the database.
*/
export class Firestore implements firestore.Firestore, FirebaseService {
private _config: FirestoreConfig;
private readonly _config: FirestoreConfig;
public readonly _databaseId: DatabaseId;

// The firestore client instance. This will be available as soon as
// configureClient is called, but any calls against it will block until
Expand All @@ -189,10 +190,6 @@ export class Firestore implements firestore.Firestore, FirebaseService {
private _firestoreClient: FirestoreClient | undefined;
public _dataConverter: UserDataConverter;

public get _databaseId(): DatabaseId {
return this._config.databaseId;
}

constructor(databaseIdOrApp: FirestoreDatabase | FirebaseApp) {
const config = new FirestoreConfig();
if (typeof (databaseIdOrApp as FirebaseApp).options === 'object') {
Expand Down Expand Up @@ -220,6 +217,7 @@ export class Firestore implements firestore.Firestore, FirebaseService {

config.settings = new FirestoreSettings({});
this._config = config;
this._databaseId = config.databaseId;
}

settings(settingsLiteral: firestore.Settings): void {
Expand Down