Skip to content

Improve test hack #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Improve test hack #2259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a71426
Improve test hack
schmidt-sebastian Oct 10, 2019
58274e6
Comment in test hack
schmidt-sebastian Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/firestore/src/local/simple_db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class SimpleDb {

async runTransaction<T>(
mode: SimpleDbTransactionMode,
objectStores: string[],
objectStores: string[],x
transactionFn: (transaction: SimpleDbTransaction) => PersistencePromise<T>
): Promise<T> {
const readonly = mode.startsWith('readonly');
Expand All @@ -273,15 +273,18 @@ export class SimpleDb {
objectStores
);
try {
// TODO(schmidt-sebastian): Remove this code/comment or find a way to
// make this a test-only setting.
// // Horrible hack to verify that idempotent functions can be run more
// // than once.
// const transactionFnResult = (idempotent && attemptNumber === 1
// ? transactionFn(transaction)
// : PersistencePromise.resolve({} as T)
// ).next(() => transactionFn(transaction))
const transactionFnResult = transactionFn(transaction)
// TODO(schmidt-sebastian): Remove this code/comment or find a way to
// make this a test-only setting.
// Horrible hack to verify that idempotent functions can be run more
// than once.
.next(result => {
if (idempotent && attemptNumber == 1) {
class DOMException {}
throw new DOMException();
}
return result;
})
.catch(error => {
// Abort the transaction if there was an error.
transaction.abort(error);
Expand Down