Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query get() method for RTDB #3812

Merged
merged 38 commits into from
Nov 17, 2020
Merged

Query get() method for RTDB #3812

merged 38 commits into from
Nov 17, 2020

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Sep 18, 2020 •
edited

Firebase API Proposal: go/rtdb-get

Github Issue: #3811

NOTE: CI will fail until https://github.com/firebase/firebase-server/pull/3298 is merged and the emulator is released.

@jmwski jmwski mentioned this pull request Sep 18, 2020
Closed
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2020 •
edited

🦋 Changeset detected

Latest commit: 2643f8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/database Minor
firebase Minor
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 18, 2020 •
edited

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (cb28261) Head (cb81ae6) Diff
    esm2017 18.6 kB 18.6 kB +37 B (+0.2%)
    main 23.8 kB 23.8 kB +37 B (+0.2%)
    module 23.3 kB 23.3 kB +37 B (+0.2%)

  • @firebase/app

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 11.1 kB 11.0 kB -96 B (-0.9%)
    esm2017 9.48 kB 9.48 kB +1 B (+0.0%)
    lite 9.11 kB 9.11 kB -1 B (-0.0%)
    lite-esm2017 7.77 kB 7.77 kB -1 B (-0.0%)
    main 10.2 kB 10.2 kB -1 B (-0.0%)
    module 11.0 kB 11.0 kB +1 B (+0.0%)
    react-native 9.87 kB 9.87 kB -1 B (-0.0%)

  • @firebase/auth

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 177 kB 180 kB +2.44 kB (+1.4%)
    main 177 kB 180 kB +2.45 kB (+1.4%)
    module 177 kB 180 kB +2.45 kB (+1.4%)

  • @firebase/component

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 5.30 kB 5.18 kB -115 B (-2.2%)

  • @firebase/database

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 270 kB 272 kB +2.20 kB (+0.8%)
    esm2017 237 kB 240 kB +3.32 kB (+1.4%)
    main 271 kB 275 kB +3.81 kB (+1.4%)
    module 269 kB 272 kB +3.79 kB (+1.4%)

  • @firebase/firestore

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 250 kB 241 kB -8.79 kB (-3.5%)
    esm2017 198 kB 190 kB -7.89 kB (-4.0%)
    main 485 kB 475 kB -9.34 kB (-1.9%)
    module 247 kB 241 kB -6.14 kB (-2.5%)
    react-native 198 kB 190 kB -7.89 kB (-4.0%)

  • @firebase/firestore/exp

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 190 kB 189 kB -1.02 kB (-0.5%)
    main 477 kB 476 kB -1.31 kB (-0.3%)
    module 190 kB 189 kB -1.02 kB (-0.5%)
    react-native 190 kB 189 kB -1.02 kB (-0.5%)

  • @firebase/firestore/lite

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 63.6 kB 62.9 kB -724 B (-1.1%)
    main 140 kB 139 kB -1.50 kB (-1.1%)
    module 63.6 kB 62.9 kB -724 B (-1.1%)
    react-native 63.8 kB 63.1 kB -724 B (-1.1%)

  • @firebase/firestore/memory

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 187 kB 177 kB -10.2 kB (-5.4%)
    esm2017 149 kB 139 kB -9.43 kB (-6.3%)
    main 358 kB 344 kB -13.9 kB (-3.9%)
    module 185 kB 177 kB -8.11 kB (-4.4%)
    react-native 149 kB 139 kB -9.44 kB (-6.3%)

  • @firebase/functions

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 10.0 kB 9.87 kB -173 B (-1.7%)
    esm2017 7.62 kB 7.69 kB +68 B (+0.9%)
    main 10.2 kB 10.3 kB +95 B (+0.9%)
    module 9.78 kB 9.87 kB +95 B (+1.0%)

  • @firebase/installations

    Type Base (cb28261) Head (cb81ae6) Diff
    esm2017 16.6 kB 16.6 kB +33 B (+0.2%)
    main 22.1 kB 22.1 kB +33 B (+0.1%)
    module 21.5 kB 21.6 kB +33 B (+0.2%)

  • @firebase/messaging

    Type Base (cb28261) Head (cb81ae6) Diff
    esm2017 26.0 kB 26.2 kB +188 B (+0.7%)
    main 34.7 kB 34.9 kB +206 B (+0.6%)
    module 34.2 kB 34.4 kB +206 B (+0.6%)

  • @firebase/performance

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 27.8 kB 27.6 kB -269 B (-1.0%)

  • @firebase/remote-config

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 22.8 kB 22.4 kB -395 B (-1.7%)
    esm2017 17.4 kB 17.4 kB +26 B (+0.1%)
    main 22.8 kB 22.8 kB +26 B (+0.1%)
    module 22.4 kB 22.4 kB +26 B (+0.1%)

  • @firebase/rules-unit-testing

    Type Base (cb28261) Head (cb81ae6) Diff
    main 7.86 kB 9.74 kB +1.88 kB (+23.9%)

  • @firebase/storage

    Type Base (cb28261) Head (cb81ae6) Diff
    esm2017 55.0 kB 49.2 kB -5.76 kB (-10.5%)
    main 61.4 kB 55.4 kB -5.96 kB (-9.7%)
    module 61.1 kB 55.1 kB -5.96 kB (-9.8%)

  • @firebase/util

    Type Base (cb28261) Head (cb81ae6) Diff
    browser 21.1 kB 20.2 kB -942 B (-4.5%)
    esm2017 18.8 kB 19.0 kB +183 B (+1.0%)
    main 21.2 kB 21.3 kB +161 B (+0.8%)
    module 20.1 kB 20.2 kB +145 B (+0.7%)

  • @firebase/webchannel-wrapper

    Type Base (cb28261) Head (cb81ae6) Diff
    esm2017 39.4 kB 39.0 kB -312 B (-0.8%)
    main 41.0 kB 46.4 kB +5.38 kB (+13.1%)
    module 40.6 kB 40.3 kB -314 B (-0.8%)

  • firebase

    Click to show 15 binary size changes.
    Type Base (cb28261) Head (cb81ae6) Diff
    firebase-analytics.js 35.8 kB 35.7 kB -99 B (-0.3%)
    firebase-app.js 20.1 kB 20.0 kB -151 B (-0.8%)
    firebase-auth.js 174 kB 176 kB +2.38 kB (+1.4%)
    firebase-database.js 190 kB 192 kB +2.77 kB (+1.5%)
    firebase-firestore.js 287 kB 280 kB -7.01 kB (-2.4%)
    firebase-firestore.memory.js 226 kB 217 kB -8.94 kB (-3.9%)
    firebase-functions.js 10.1 kB 9.99 kB -91 B (-0.9%)
    firebase-installations.js 19.1 kB 19.0 kB -135 B (-0.7%)
    firebase-messaging.js 40.9 kB 40.8 kB -83 B (-0.2%)
    firebase-performance-standalone.es2017.js 71.8 kB 71.7 kB -93 B (-0.1%)
    firebase-performance-standalone.js 48.2 kB 48.1 kB -120 B (-0.2%)
    firebase-performance.js 38.6 kB 38.5 kB -135 B (-0.3%)
    firebase-remote-config.js 36.9 kB 36.8 kB -110 B (-0.3%)
    firebase-storage.js 39.7 kB 36.0 kB -3.69 kB (-9.3%)
    firebase.js 829 kB 824 kB -4.83 kB (-0.6%)

Test Logs

@schmidt-sebastian schmidt-sebastian mentioned this pull request Sep 22, 2020
Closed
schmidt-sebastian
schmidt-sebastian reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good. Some nits. Thanks!

packages/database/src/api/Query.ts Outdated Show resolved Hide resolved
packages/database/src/core/PersistentConnection.ts Outdated Show resolved Hide resolved
packages/database/src/core/PersistentConnection.ts Outdated Show resolved Hide resolved
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
schmidt-sebastian
schmidt-sebastian approved these changes Oct 22, 2020
View reviewed changes
packages/database/test/query.test.ts Outdated Show resolved Hide resolved
packages/database/src/core/Repo.ts Outdated Show resolved Hide resolved
@schmidt-sebastian schmidt-sebastian mentioned this pull request Oct 27, 2020
Merged
@jmwski jmwski assigned schmidt-sebastian and unassigned jmwski Nov 4, 2020
@schmidt-sebastian schmidt-sebastian removed their assignment Nov 13, 2020
@jmwski
Copy link
Contributor Author

jmwski commented Nov 13, 2020

@Feiyang1 Adding you because of the database emulator update.

Feiyang1
Feiyang1 suggested changes Nov 17, 2020
View reviewed changes
.changeset/many-snails-kneel.md Show resolved Hide resolved
packages/database/src/core/Repo.ts Outdated Show resolved Hide resolved
@Feiyang1 Feiyang1 assigned jmwski and unassigned Feiyang1 Nov 17, 2020
jmwski and others added 2 commits November 17, 2020 14:54
@jmwski @Feiyang1
Update .changeset/many-snails-kneel.md
008e6fb 
Co-authored-by: Feiyang <feiyangc@google.com>
@jmwski @Feiyang1
Update packages/database/src/core/Repo.ts
2643f8a 
Co-authored-by: Feiyang <feiyangc@google.com>
@jmwski jmwski requested a review from Feiyang1 November 17, 2020 21:42
@jmwski jmwski merged commit 34973cd into master Nov 17, 2020
@jmwski jmwski deleted the jw/rtdb-query-get branch November 17, 2020 22:04
@google-oss-bot google-oss-bot mentioned this pull request Nov 17, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@jmwski jmwski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmwski @google-oss-bot @Feiyang1 @schmidt-sebastian