Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe fix deprecation warning #5739

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Maybe fix deprecation warning #5739

merged 1 commit into from
Jan 25, 2022

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Nov 16, 2021

Related to #1847. I don't know if this works.

Note this would still warn if you don't pass the persistence layer yourself. But at least it shouldn't warn if you do.

Sorry for lack of detail, @hsubox76 has context on the conversation

Related to firebase#1847. I don't know if this works.
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2021

⚠️ No Changeset found

Latest commit: 7a51f65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76
Copy link
Contributor

hsubox76 commented Jan 24, 2022

Oops, sorry I forgot to ask until now but can you add a changeset? Just yarn changeset and follow prompts.

Testing checks out so I think that's all I need to merge.

Edit: Actually I can add it in an additional PR.

@hsubox76 hsubox76 merged commit e80d18d into firebase:master Jan 25, 2022
hsubox76 added a commit that referenced this pull request Jan 25, 2022
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants