Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changeset for PR #5739 #5927

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Add changeset for PR #5739 #5927

merged 3 commits into from
Jan 25, 2022

Conversation

hsubox76
Copy link
Contributor

Changeset for #5739

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2022

🦋 Changeset detected

Latest commit: d3bd3c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits for you to look at, thanks!

'@firebase/auth': patch
---

Prevent React Native logging a warning about deprecation of `AsyncStorage` if user has provided the non-deprecated version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preposition could clarify a little: "Prevent React Native from logging..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

'@firebase/auth': patch
---

Prevent React Native logging a warning about deprecation of `AsyncStorage` if user has provided the non-deprecated version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "user" definitely the right term? Or could it be "the developer" or even "the package.json file" or wherever this is defined?

I clearly do not know :) But if we go with this, I'd suggest "if the user"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"developer" makes sense.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsubox76 hsubox76 merged commit 2820674 into master Jan 25, 2022
@hsubox76 hsubox76 deleted the ch-rn-asyncstorage branch January 25, 2022 18:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 25, 2022

@google-oss-bot google-oss-bot mentioned this pull request Jan 26, 2022
@firebase firebase locked and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants