Add changeset for PR #5739 #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d3bd3c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
egilmorez
reviewed
Jan 25, 2022
.changeset/yellow-suns-clean.md
Outdated
| '@firebase/auth': patch | ||
| --- | ||
|
|
||
| Prevent React Native logging a warning about deprecation of `AsyncStorage` if user has provided the non-deprecated version. |
There was a problem hiding this comment.
The preposition could clarify a little: "Prevent React Native from logging..."
.changeset/yellow-suns-clean.md
Outdated
| '@firebase/auth': patch | ||
| --- | ||
|
|
||
| Prevent React Native logging a warning about deprecation of `AsyncStorage` if user has provided the non-deprecated version. |
There was a problem hiding this comment.
Is "user" definitely the right term? Or could it be "the developer" or even "the package.json file" or wherever this is defined?
I clearly do not know :) But if we go with this, I'd suggest "if the user"
There was a problem hiding this comment.
"developer" makes sense.
Size Report 1Affected ProductsNo changes between base commit (e80d18d) and merge commit (fb5e8cd).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (e80d18d) and merge commit (fb5e8cd).Test Logs |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset for #5739