Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Index Schema #5954

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Add Index Schema #5954

merged 2 commits into from
Feb 1, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

⚠️ No Changeset found

Latest commit: 8045367

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (6555aa7)Merge (1f916a1)Diff
    browser229 kB230 kB+813 B (+0.4%)
    esm5286 kB287 kB+792 B (+0.3%)
    main456 kB457 kB+1.36 kB (+0.3%)
    module229 kB230 kB+813 B (+0.4%)
    react-native229 kB230 kB+813 B (+0.4%)
  • @firebase/firestore-lite

    TypeBase (6555aa7)Merge (1f916a1)Diff
    browser72.7 kB72.7 kB+35 B (+0.0%)
    esm586.0 kB86.0 kB+40 B (+0.0%)
    main125 kB125 kB+44 B (+0.0%)
    module72.7 kB72.7 kB+35 B (+0.0%)
    react-native72.9 kB72.9 kB+35 B (+0.0%)
  • bundle

    12 size changes

    TypeBase (6555aa7)Merge (1f916a1)Diff
    firestore (Persistence)230 kB231 kB+798 B (+0.3%)
    firestore (Query Cursors)189 kB189 kB+53 B (+0.0%)
    firestore (Query)190 kB190 kB+53 B (+0.0%)
    firestore (Read data once)179 kB179 kB+53 B (+0.0%)
    firestore (Realtime updates)181 kB181 kB+53 B (+0.0%)
    firestore (Transaction)163 kB163 kB+45 B (+0.0%)
    firestore (Write data)163 kB163 kB+45 B (+0.0%)
    firestore-lite (Query Cursors)56.6 kB56.6 kB+36 B (+0.1%)
    firestore-lite (Query)59.6 kB59.7 kB+36 B (+0.1%)
    firestore-lite (Read data once)44.1 kB44.2 kB+36 B (+0.1%)
    firestore-lite (Transaction)61.5 kB61.5 kB+36 B (+0.1%)
    firestore-lite (Write data)47.0 kB47.0 kB+36 B (+0.1%)

  • firebase

    TypeBase (6555aa7)Merge (1f916a1)Diff
    firebase-compat.js754 kB754 kB+777 B (+0.1%)
    firebase-firestore-compat.js281 kB282 kB+777 B (+0.3%)
    firebase-firestore-lite.js249 kB249 kB+111 B (+0.0%)
    firebase-firestore.js775 kB778 kB+2.69 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/15CGlrR91g.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 31, 2022

Size Analysis Report 1

This report is too large (684,164 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/aqQZ0J8zc1.html

*/
export const SCHEMA_VERSION = 11;
export const SCHEMA_VERSION = INDEXING_ENABLED ? 12 : 11;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultranit: use the const defined below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 1, 2022
@schmidt-sebastian schmidt-sebastian merged commit 4cec423 into master Feb 1, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/indexschema branch February 1, 2022 18:38
@firebase firebase locked and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants