Skip to content

Support converter that returns undefined. #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 30, 2023
Merged

Support converter that returns undefined. #7738

merged 3 commits into from
Oct 30, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 30, 2023 •
edited
Loading

This is to resolve issue: #7719

A converter can return undefined, so we should not fail when data is undefined in compat library.

@tom-andersen tom-andersen requested review from a team as code owners October 30, 2023 15:20
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 2413878

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/firestore-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 30, 2023 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore-compat

    TypeBase (12ad9f1)Merge (1d02f5e)Diff
    browser20.5 kB20.6 kB+48 B (+0.2%)
    esm527.6 kB27.7 kB+48 B (+0.2%)
    main20.9 kB21.0 kB+48 B (+0.2%)
    module20.5 kB20.6 kB+48 B (+0.2%)
    react-native20.5 kB20.6 kB+48 B (+0.2%)

  • firebase

    TypeBase (12ad9f1)Merge (1d02f5e)Diff
    firebase-compat.js778 kB778 kB+27 B (+0.0%)
    firebase-firestore-compat.js340 kB340 kB+27 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cpUb5vz6xY.html

@tom-andersen tom-andersen requested a review from a team as a code owner October 30, 2023 16:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 30, 2023 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (12ad9f1) and merge commit (5076096).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yS3pZhUX5H.html

@tom-andersen tom-andersen requested a review from dconeybe October 30, 2023 16:08
dconeybe
dconeybe approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@dconeybe dconeybe assigned tom-andersen and unassigned dconeybe Oct 30, 2023
@tom-andersen tom-andersen merged commit 67c5a90 into master Oct 30, 2023
@tom-andersen tom-andersen deleted the tomandersen/issue7719 branch October 30, 2023 18:09
@tom-andersen tom-andersen mentioned this pull request Oct 30, 2023
Closed
@google-oss-bot google-oss-bot mentioned this pull request Nov 7, 2023
Merged
prameshj pushed a commit that referenced this pull request Nov 13, 2023
@tom-andersen @prameshj
Support converter that returns undefined. (#7738)
a945f11 
* Support converter that returns undefined.

* Changeset

* Format
@firebase firebase locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@tom-andersen tom-andersen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tom-andersen @google-oss-bot @dconeybe