Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub ref to get PR head #8287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 31, 2024

The pull request head ref name is local to its originating repository. For pull requests from forks, that ref is unlikely to exist.

GitHub has special magic refs (refs/pull//<head|merge>) that can be used to reference the pull request from the destination repository's perspective.

Note that the merge magic ref is not instance and is slightly quirky. Here, we're using the head ref which is less quirky.

Discussion

#8274
#8275 (comment)

Testing

Requires a second copy linked copy of a repository.

API Changes

The pull request head ref name is local to its originating repository.
For pull requests from forks, that ref is unlikely to exist.

GitHub has special magic refs (refs/pull/<number>/<head|merge>) that can
be used to reference the pull request from the destination repository's
perspective.

Note that the merge magic ref is not instance and is slightly quirky.
Here, we're using the head ref which is less quirky.
@jsoref jsoref requested a review from a team as a code owner May 31, 2024 20:58
Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: 39e1f15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dlarocque dlarocque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants